diff options
| author | Yuki Okushi <jtitor@2k36.org> | 2021-08-02 11:03:19 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-02 11:03:19 +0900 |
| commit | a03d6da3ef7852cbcfcf98b7639b529b96587ca3 (patch) | |
| tree | 07b433868914e1d64e897429fafc0120b90c9972 /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp | |
| parent | 016612dc8d9ed850a066bccd42e4d6f7816f0484 (diff) | |
| parent | a26237e634be7f94dbd40cc1204514f2b4c380d2 (diff) | |
| download | rust-a03d6da3ef7852cbcfcf98b7639b529b96587ca3.tar.gz rust-a03d6da3ef7852cbcfcf98b7639b529b96587ca3.zip | |
Rollup merge of #86439 - CDirkx:ip-protocol-assignment, r=m-ou-se
Remove `Ipv4Addr::is_ietf_protocol_assignment` This PR removes the unstable method `Ipv4Addr::is_ietf_protocol_assignment`, as I suggested in https://github.com/rust-lang/rust/issues/85612#issuecomment-847863404. The method was added in #60145, as far as I can tell primarily for the implementation of `Ipv4Addr::is_global` (addresses reserved for IETF protocol assignment are not globally reachable unless otherwise specified). The method was added in 2019, but I haven't been able to find any open-source code using this method so far. I'm also having a hard time coming up with a usecase for specifically this method; knowing that an address is reserved for future protocols doesn't allow you to do much with it, especially since now some of those addresses are indeed assigned to a protocol and have their own behaviour (and might even be defined to be globally reachable, so if that is what you care about it is always more accurate to call `!is_global()`, instead of `is_ietf_protocol_assignment()`). Because of these reasons, I propose removing the method (or alternatively make it a private helper for `is_global`) and also not introduce `Ipv6Addr::is_ietf_protocol_assignment` and `IpAddr::is_ietf_protocol_assignment` in the future.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions