about summary refs log tree commit diff
path: root/compiler/rustc_mir/src/transform/coverage/graph.rs
diff options
context:
space:
mode:
authorTheodore Cipicchio <okready@users.noreply.github.com>2020-09-04 09:34:11 -0700
committerTheodore Cipicchio <okready@users.noreply.github.com>2020-09-04 13:58:59 -0700
commitc989de52b8ad76439f6178170d94ead64ee3ffc7 (patch)
treec8d80a2b0f3c718b0311fee018404ad459160845 /compiler/rustc_mir/src/transform/coverage/graph.rs
parentd2454643e137bde519786ee9e650c455d7ad6f34 (diff)
downloadrust-c989de52b8ad76439f6178170d94ead64ee3ffc7.tar.gz
rust-c989de52b8ad76439f6178170d94ead64ee3ffc7.zip
Add is_enclave_range/is_user_range overflow checks
Functions such as `is_enclave_range` and `is_user_range` in
`sgx::os::fortanix_sgx::mem` are often used to make sure memory ranges
passed to an enclave from untrusted code or passed to other trusted code
functions are safe to use for their intended purpose. Currently, these
functions do not perform any checks to make sure the range provided
doesn't overflow when adding the range length to the base address. While
debug builds will panic if overflow occurs, release builds will simply
wrap the result, leading to false positive results for either function.
The burden is placed on application authors to know to perform overflow
checks on their own before calling these functions, which can easily
lead to security vulnerabilities if omitted. Additionally, since such
checks are performed in the Intel SGX SDK versions of these functions,
developers migrating from Intel SGX SDK code may expect these functions
to operate the same.

This commit adds explicit overflow checking to `is_enclave_range` and
`is_user_range`, returning `false` if overflow occurs in order to
prevent misuse of invalid memory ranges. It also alters the checks to
account for ranges that lie exactly at the end of the address space,
where calculating `p + len` would overflow despite the range being
valid.
Diffstat (limited to 'compiler/rustc_mir/src/transform/coverage/graph.rs')
0 files changed, 0 insertions, 0 deletions