about summary refs log tree commit diff
path: root/compiler/rustc_mir_transform/src/coverage/graph.rs
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2024-12-19 15:26:16 +0100
committerGitHub <noreply@github.com>2024-12-19 15:26:16 +0100
commit57cbd078f2748d9af7ef76694becc7c9096140b9 (patch)
treed47be4b1f9e939b186b18a5db1ba3bc2e96c58fc /compiler/rustc_mir_transform/src/coverage/graph.rs
parentfc11b5a0f41ebae6ad9020dc893d52d1233b5fb8 (diff)
parentaced4dcf1047aab08b769b34fae9d4ba7de87f04 (diff)
downloadrust-57cbd078f2748d9af7ef76694becc7c9096140b9.tar.gz
rust-57cbd078f2748d9af7ef76694becc7c9096140b9.zip
Rollup merge of #134497 - Zalathar:spans, r=jieyouxu
coverage: Store coverage source regions as `Span` until codegen (take 2)

This is an attempt to re-land #133418:

> Historically, coverage spans were converted into line/column coordinates during the MIR instrumentation pass.

> This PR moves that conversion step into codegen, so that coverage spans spend most of their time stored as Span instead.

> In addition to being conceptually nicer, this also reduces the size of coverage mappings in MIR, because Span is smaller than 4x u32.

That PR was reverted by #133608, because in some circumstances not covered by our test suite we were emitting coverage metadata that was causing `llvm-cov` to exit with an error (#133606).

---

The implementation here is *mostly* the same, but adapted for subsequent changes in the relevant code (e.g. #134163).

I believe that the changes in #134163 should be sufficient to prevent the problem that required the original PR to be reverted. But I haven't been able to reproduce the original breakage in a regression test, and the `llvm-cov` error message is extremely unhelpful, so I can't completely rule out the possibility of this breaking again.

r? jieyouxu (reviewer of the original PR)
Diffstat (limited to 'compiler/rustc_mir_transform/src/coverage/graph.rs')
0 files changed, 0 insertions, 0 deletions