diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2023-04-30 01:14:58 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-30 01:14:58 +0200 |
| commit | 791d33c5ebc59403fded3ed0cff6926623cba12a (patch) | |
| tree | 559aa03948eca20ce3ddba5a3ffd961b638acb1a /compiler/rustc_mir_transform | |
| parent | e4daa810ffd10a389bfe51250fb8101b6ee11656 (diff) | |
| parent | 107d480892aeedf2b02b70788a3668498fa72084 (diff) | |
| download | rust-791d33c5ebc59403fded3ed0cff6926623cba12a.tar.gz rust-791d33c5ebc59403fded3ed0cff6926623cba12a.zip | |
Rollup merge of #110973 - bindsdev:packed-struct-ref-diagnostic-note, r=compiler-errors
improve error notes for packed struct reference diagnostic Addresses #110199
Diffstat (limited to 'compiler/rustc_mir_transform')
| -rw-r--r-- | compiler/rustc_mir_transform/src/check_packed_ref.rs | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/compiler/rustc_mir_transform/src/check_packed_ref.rs b/compiler/rustc_mir_transform/src/check_packed_ref.rs index f5f1c1010e1..b9bc89fcf8f 100644 --- a/compiler/rustc_mir_transform/src/check_packed_ref.rs +++ b/compiler/rustc_mir_transform/src/check_packed_ref.rs @@ -56,8 +56,11 @@ impl<'tcx> Visitor<'tcx> for PackedRefChecker<'_, 'tcx> { "reference to packed field is unaligned" ) .note( - "fields of packed structs are not properly aligned, and creating \ - a misaligned reference is undefined behavior (even if that \ + "packed structs are only aligned by one byte, and many modern architectures \ + penalize unaligned field accesses" + ) + .note( + "creating a misaligned reference is undefined behavior (even if that \ reference is never dereferenced)", ).help( "copy the field contents to a local variable, or replace the \ |