about summary refs log tree commit diff
path: root/compiler/rustc_monomorphize
diff options
context:
space:
mode:
authorMark Rousskov <mark.simulacrum@gmail.com>2025-06-22 17:51:56 -0400
committerMark Rousskov <mark.simulacrum@gmail.com>2025-06-22 17:52:49 -0400
commit928564c7bfb395e1e5bd34d8913b7627ee4d1130 (patch)
treec34b6152a04edcf5303a142c7a226576e0ee79fa /compiler/rustc_monomorphize
parentd4e1159b8c97478778b09a4cc1c7adce5653b8bf (diff)
downloadrust-928564c7bfb395e1e5bd34d8913b7627ee4d1130.tar.gz
rust-928564c7bfb395e1e5bd34d8913b7627ee4d1130.zip
Stop collecting unmentioned constants
This avoids generating useless dead LLVM IR.
Diffstat (limited to 'compiler/rustc_monomorphize')
-rw-r--r--compiler/rustc_monomorphize/src/collector.rs14
1 files changed, 8 insertions, 6 deletions
diff --git a/compiler/rustc_monomorphize/src/collector.rs b/compiler/rustc_monomorphize/src/collector.rs
index 173030e0326..3eb9a9dc850 100644
--- a/compiler/rustc_monomorphize/src/collector.rs
+++ b/compiler/rustc_monomorphize/src/collector.rs
@@ -1481,12 +1481,14 @@ impl<'v> RootCollector<'_, 'v> {
                 // Const items only generate mono items if they are actually used somewhere.
                 // Just declaring them is insufficient.
 
-                // But even just declaring them must collect the items they refer to
-                // unless their generics require monomorphization.
-                if !self.tcx.generics_of(id.owner_id).own_requires_monomorphization()
-                    && let Ok(val) = self.tcx.const_eval_poly(id.owner_id.to_def_id())
-                {
-                    collect_const_value(self.tcx, val, self.output);
+                // If we're collecting items eagerly, then recurse into all constants.
+                // Otherwise the value is only collected when explicitly mentioned in other items.
+                if self.strategy == MonoItemCollectionStrategy::Eager {
+                    if !self.tcx.generics_of(id.owner_id).own_requires_monomorphization()
+                        && let Ok(val) = self.tcx.const_eval_poly(id.owner_id.to_def_id())
+                    {
+                        collect_const_value(self.tcx, val, self.output);
+                    }
                 }
             }
             DefKind::Impl { .. } => {