diff options
| author | León Orell Valerian Liehr <me@fmease.dev> | 2024-02-18 05:10:16 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-18 05:10:16 +0100 |
| commit | 6499eb5577a636c0dd40f8dd48df8f89a2bf958d (patch) | |
| tree | 08eaa301105a527e37c18a61713cd557bae6cbba /compiler/rustc_parse/src/errors.rs | |
| parent | fb5982f14e5bc943df9f884360562f2aec12ed83 (diff) | |
| parent | 9b3fcf9ad44faa6362be348ef233bbc81d128308 (diff) | |
| download | rust-6499eb5577a636c0dd40f8dd48df8f89a2bf958d.tar.gz rust-6499eb5577a636c0dd40f8dd48df8f89a2bf958d.zip | |
Rollup merge of #121100 - estebank:issue-71252, r=compiler-errors
Detect when method call on argument could be removed to fulfill failed trait bound
When encountering
```rust
struct Foo;
struct Bar;
impl From<Bar> for Foo {
fn from(_: Bar) -> Self { Foo }
}
fn qux(_: impl From<Bar>) {}
fn main() {
qux(Bar.into());
}
```
Suggest removing `.into()`:
```
error[E0283]: type annotations needed
--> f100.rs:8:13
|
8 | qux(Bar.into());
| --- ^^^^
| |
| required by a bound introduced by this call
|
= note: cannot satisfy `_: From<Bar>`
note: required by a bound in `qux`
--> f100.rs:6:16
|
6 | fn qux(_: impl From<Bar>) {}
| ^^^^^^^^^ required by this bound in `qux`
help: try using a fully qualified path to specify the expected types
|
8 | qux(<Bar as Into<T>>::into(Bar));
| +++++++++++++++++++++++ ~
help: consider removing this method call, as the receiver has type `Bar` and `Bar: From<Bar>` trivially holds
|
8 - qux(Bar.into());
8 + qux(Bar);
|
```
Fix #71252
Diffstat (limited to 'compiler/rustc_parse/src/errors.rs')
0 files changed, 0 insertions, 0 deletions
