diff options
| author | bors <bors@rust-lang.org> | 2024-06-08 19:40:23 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2024-06-08 19:40:23 +0000 |
| commit | f21554f7f0ff447b803961c51acafde04553c1ed (patch) | |
| tree | f184829a7b0d0c59e4aef1bad6a9cf71abab9385 /compiler/rustc_parse/src/errors.rs | |
| parent | 565cadb514d35e7b851540edbc172af0f606014f (diff) | |
| parent | 0a190e8d2d9bbe0b417b6f160042b816b31cec7b (diff) | |
| download | rust-f21554f7f0ff447b803961c51acafde04553c1ed.tar.gz rust-f21554f7f0ff447b803961c51acafde04553c1ed.zip | |
Auto merge of #126121 - Kobzol:runmake-cmd-wrapper, r=jieyouxu
Add a custom Command wrapper to `run-make-support` This should make it easier to make sure that we check process exit codes, and it should also make checking of stdout/stderr less verbose and more explicit in run-make tests. I prefer the `run()/run_fail().assert(...)` style to something like `run_fail_assert_exit_code`, because the former is more composable. Regarding https://github.com/rust-lang/rust/issues/125747, I'm not sure if we really need a custom trait, I think that we can get far enough with just `Deref` on the `Cc/Clang/Rustc/Rustdoc/...` structs. But now that these structs don't even need `command_output` anymore, I think that they are fine-ish as they are with the macro. Related issues: https://github.com/rust-lang/rust/issues/125617, https://github.com/rust-lang/rust/issues/125747 Fixes: https://github.com/rust-lang/rust/issues/125617 (because `command_output` is no longer a public method) r? `@jieyouxu`
Diffstat (limited to 'compiler/rustc_parse/src/errors.rs')
0 files changed, 0 insertions, 0 deletions