about summary refs log tree commit diff
path: root/compiler/rustc_parse/src/parser
diff options
context:
space:
mode:
authorNicholas Nethercote <n.nethercote@gmail.com>2025-03-25 20:52:17 +1100
committerNicholas Nethercote <n.nethercote@gmail.com>2025-03-26 06:56:11 +1100
commitffee55c18c19c551d58a6d68e1b3feb7618d0455 (patch)
treeff36133677d1bfde97a48bb88a1712bd194a0fe9 /compiler/rustc_parse/src/parser
parentaa8f0fd7163a2f23aa958faed30c9c2b77b934a5 (diff)
downloadrust-ffee55c18c19c551d58a6d68e1b3feb7618d0455.tar.gz
rust-ffee55c18c19c551d58a6d68e1b3feb7618d0455.zip
rustdoc: Rearrange `Item`/`ItemInner`.
The `Item` struct is 48 bytes and contains a `Box<ItemInner>`;
`ItemInner` is 104 bytes. This is an odd arrangement. Normally you'd
have one of the following.

- A single large struct, which avoids the allocation for the `Box`, but
  can result in lots of wasted space in unused parts of a container like
  `Vec<Item>`, `HashSet<Item>`, etc.

- Or, something like `struct Item(Box<ItemInner>)`, which requires the
  `Box` allocation but gives a very small Item size, which is good for
  containers like `Vec<Item>`.

`Item`/`ItemInner` currently gets the worst of both worlds: it always
requires a `Box`, but `Item` is also pretty big and so wastes space in
containers. It would make sense to push it in one direction or the
other. #138916 showed that the first option is a regression for rustdoc,
so this commit does the second option, which improves speed and reduces
memory usage.
Diffstat (limited to 'compiler/rustc_parse/src/parser')
0 files changed, 0 insertions, 0 deletions