diff options
| author | Jacob Pratt <jacob@jhpratt.dev> | 2025-01-25 23:27:01 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-25 23:27:01 -0500 |
| commit | 64550d1ed8023bea8668888ea8cfa91f4978875f (patch) | |
| tree | 822f92973f9c6feeed8eb1b7099f35533d8e95de /compiler/rustc_passes/src/errors.rs | |
| parent | 182ccfa11fe5d7a3a6e9cc0d2100159dcd9963d2 (diff) | |
| parent | 1dfc437aaf09185c9830b6b5214bc2a089fd297f (diff) | |
| download | rust-64550d1ed8023bea8668888ea8cfa91f4978875f.tar.gz rust-64550d1ed8023bea8668888ea8cfa91f4978875f.zip | |
Rollup merge of #136032 - estebank:issue-136028, r=SparrowLii
Account for mutable borrow in argument suggestion
```
error: value assigned to `object` is never read
--> $DIR/mut-arg-of-borrowed-type-meant-to-be-arg-of-mut-borrow.rs:21:5
|
LL | object = &mut object2;
| ^^^^^^
|
help: you might have meant to mutate the pointed at value being passed in, instead of changing the reference in the local binding
|
LL ~ fn change_object3(object: &mut Object) {
LL |
LL | let object2 = Object;
LL ~ *object = object2;
|
```
instead of
```
error: value assigned to `object` is never read
--> $DIR/mut-arg-of-borrowed-type-meant-to-be-arg-of-mut-borrow.rs:21:5
|
LL | object = &mut object2;
| ^^^^^^
|
help: you might have meant to mutate the pointed at value being passed in, instead of changing the reference in the local binding
|
LL ~ fn change_object3(object: &mut mut Object) {
LL |
LL | let object2 = Object;
LL ~ *object = object2;
|
```
Fix #136028.
Diffstat (limited to 'compiler/rustc_passes/src/errors.rs')
| -rw-r--r-- | compiler/rustc_passes/src/errors.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/rustc_passes/src/errors.rs b/compiler/rustc_passes/src/errors.rs index 196a0a46962..0aa50ad19ff 100644 --- a/compiler/rustc_passes/src/errors.rs +++ b/compiler/rustc_passes/src/errors.rs @@ -1791,7 +1791,7 @@ pub(crate) struct UnusedAssign { pub(crate) struct UnusedAssignSuggestion { pub pre: &'static str, #[suggestion_part(code = "{pre}mut ")] - pub ty_span: Span, + pub ty_span: Option<Span>, #[suggestion_part(code = "")] pub ty_ref_span: Span, #[suggestion_part(code = "*")] |
