summary refs log tree commit diff
path: root/compiler/rustc_pattern_analysis/src/lib.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-01-15 09:20:46 +0000
committerbors <bors@rust-lang.org>2024-01-15 09:20:46 +0000
commit1ead4761e9e2f056385768614c23ffa7acb6a19e (patch)
tree066a93a12afdeeffafe7f7199d85fff0d4f9e0a4 /compiler/rustc_pattern_analysis/src/lib.rs
parent73252d51d13c0e4f872c3c51defcf48174860ef6 (diff)
parentb858c591dd85f51bb515f492cfa8a0252339ddb9 (diff)
downloadrust-1ead4761e9e2f056385768614c23ffa7acb6a19e.tar.gz
rust-1ead4761e9e2f056385768614c23ffa7acb6a19e.zip
Auto merge of #119878 - scottmcm:inline-always-unwrap, r=workingjubilee
Tune the inlinability of `unwrap`

Fixes #115463
cc `@thomcc`

This tweaks `unwrap` on ~~`Option` &~~ `Result` to be two parts:
- `#[inline(always)]` for checking the discriminant
- `#[cold]` for actually panicking

The idea here is that checking the discriminant on a `Result` ~~or `Option`~~ should always be trivial enough to be worth inlining, even in `opt-level=z`, especially compared to passing it to a function.

As seen in the issue and codegen test, this will hopefully help particularly for things like `.try_into().unwrap()`s that are actually infallible, but in a way that's only visible with the inlining.

EDIT: I've restricted this to `Result` to avoid combining effects
Diffstat (limited to 'compiler/rustc_pattern_analysis/src/lib.rs')
0 files changed, 0 insertions, 0 deletions