about summary refs log tree commit diff
path: root/compiler/rustc_pattern_analysis/src
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2025-02-17 06:38:15 +0100
committerGitHub <noreply@github.com>2025-02-17 06:38:15 +0100
commitfae72a07dd43775e39d94698c165f9a007115172 (patch)
tree1a51b320265741ca5fff76b05f7666d1d11ea641 /compiler/rustc_pattern_analysis/src
parent2a25a16c570e0f7d72b272e63347c28620abb761 (diff)
parent0f220efb1a9c1bab199baadcb01ce2129bce0037 (diff)
downloadrust-fae72a07dd43775e39d94698c165f9a007115172.tar.gz
rust-fae72a07dd43775e39d94698c165f9a007115172.zip
Rollup merge of #137105 - zachs18:cow-derefpure-restrict, r=Nadrieril
Restrict DerefPure for Cow<T> impl to T = impl Clone, [impl Clone], str.

Fixes #136046

`feature(deref_patterns)` tracking issue: https://github.com/rust-lang/rust/issues/87121

`Cow<'_, T>` should only implement `DerefPure` if its `Deref` impl is pure, which requires `<T::Owned as Borrow<T>>::borrow`  to be pure. This PR restricts `impl DerefPure for Cow<'_, T>` to `T: Sized + Clone`, `T = [U: Clone]`, and `T = str` (for all of whom `<T::Owned as Borrow<T>>::borrow` is implemented in the stdlib and is pure).

cc ``@Nadrieril``

------

An alternate approach would be to introduce a new `unsafe trait BorrowPure<T>` analogous to `DerefPure`  that could be implemented for `T: Sized`, `&T`, `&mut T`, `String`, `Vec`, `Box`, `PathBuf`, `OsString`, etc. https://github.com/rust-lang/rust/compare/master...zachs18:borrow-pure-trait
Diffstat (limited to 'compiler/rustc_pattern_analysis/src')
0 files changed, 0 insertions, 0 deletions