about summary refs log tree commit diff
path: root/compiler/rustc_plugin_impl/src
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2023-06-30 08:01:12 +0200
committerGitHub <noreply@github.com>2023-06-30 08:01:12 +0200
commit6c22e0419f2307710204d1b6051cb3b8755fa9fc (patch)
treed9106a9f55205431f219a8de0b9ec688be18a0ca /compiler/rustc_plugin_impl/src
parent016c306ce64560c4741ff7b5893b0e00cfa3d56f (diff)
parent679c5be4057597bf6265663d740dbf14210c3291 (diff)
downloadrust-6c22e0419f2307710204d1b6051cb3b8755fa9fc.tar.gz
rust-6c22e0419f2307710204d1b6051cb3b8755fa9fc.zip
Rollup merge of #111403 - y21:suggest-slice-swap, r=compiler-errors
suggest `slice::swap` for `mem::swap(&mut x[0], &mut x[1])` borrowck error

Recently saw someone ask why this code (example slightly modified):
```rs
fn main() {
  let mut foo = [1, 2];
  std::mem::swap(&mut foo[0], &mut foo[1]);
}
```
triggers this error and how to fix it:
```
error[E0499]: cannot borrow `foo[_]` as mutable more than once at a time
 --> src/main.rs:4:33
  |
4 |     std::mem::swap(&mut foo[0], &mut foo[1]);
  |     -------------- -----------  ^^^^^^^^^^^ second mutable borrow occurs here
  |     |              |
  |     |              first mutable borrow occurs here
  |     first borrow later used by call
  |
  = help: consider using `.split_at_mut(position)` or similar method to obtain two mutable non-overlapping sub-slices
```
The current help message is nice and goes in the right direction, but I think we can do better for this specific instance and suggest `slice::swap`, which makes this compile
Diffstat (limited to 'compiler/rustc_plugin_impl/src')
0 files changed, 0 insertions, 0 deletions