diff options
| author | bors <bors@rust-lang.org> | 2023-12-26 12:27:29 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-12-26 12:27:29 +0000 |
| commit | 2fe50cd72c476ebacdedb14893e9632b4de961c2 (patch) | |
| tree | 646eae2f31ec0a7ad1dbef7bce78bf331efda17b /compiler/rustc_query_impl/src | |
| parent | ea7ef7b6c224226a4bd9f9796de39d57b527f7f9 (diff) | |
| parent | cb6d033316bdc2a1c5c1c0e04b297fbbb81eafca (diff) | |
| download | rust-2fe50cd72c476ebacdedb14893e9632b4de961c2.tar.gz rust-2fe50cd72c476ebacdedb14893e9632b4de961c2.zip | |
Auto merge of #119129 - jyn514:verbose, r=compiler-errors,estebank
rework `-Zverbose` implements the changes described in https://github.com/rust-lang/compiler-team/issues/706 the first commit is only a name change from `-Zverbose` to `-Zverbose-internals` and does not change behavior. the second commit changes diagnostics. possible follow up work: - `ty::pretty` could print more info with `--verbose` than it does currently. `-Z verbose-internals` shows too much info in a way that's not helpful to users. michael had ideas about this i didn't fully understand: https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408984200 - `--verbose` should imply `-Z write-long-types-to-disk=no`. the code in `ty_string_with_limit` should take `--verbose` into account (apparently this affects `Ty::sort_string`, i'm not familiar with this code). writing a file to disk should suggest passing `--verbose`. r? `@compiler-errors` cc `@estebank`
Diffstat (limited to 'compiler/rustc_query_impl/src')
| -rw-r--r-- | compiler/rustc_query_impl/src/plumbing.rs | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/compiler/rustc_query_impl/src/plumbing.rs b/compiler/rustc_query_impl/src/plumbing.rs index 0971f2d75da..f131a0f7593 100644 --- a/compiler/rustc_query_impl/src/plumbing.rs +++ b/compiler/rustc_query_impl/src/plumbing.rs @@ -315,8 +315,11 @@ pub(crate) fn create_query_frame< ty::print::with_forced_impl_filename_line!(do_describe(tcx, key)) ) ); - let description = - if tcx.sess.verbose() { format!("{description} [{name:?}]") } else { description }; + let description = if tcx.sess.verbose_internals() { + format!("{description} [{name:?}]") + } else { + description + }; let span = if kind == dep_graph::dep_kinds::def_span || with_no_queries() { // The `def_span` query is used to calculate `default_span`, // so exit to avoid infinite recursion. |
