about summary refs log tree commit diff
path: root/compiler/rustc_resolve/src/check_unused.rs
diff options
context:
space:
mode:
authorPietro Albini <pietro@pietroalbini.org>2024-04-01 23:53:17 +0200
committerPietro Albini <pietro@pietroalbini.org>2024-04-14 18:45:27 +0200
commit2ec337c19336845b371dcd6bc1369e6b34124afd (patch)
tree08f724fe515d197d31420e9e85e32c94ce0050f6 /compiler/rustc_resolve/src/check_unused.rs
parent2c26072d8cdca85e813b423f65632911f4781ff5 (diff)
downloadrust-2ec337c19336845b371dcd6bc1369e6b34124afd.tar.gz
rust-2ec337c19336845b371dcd6bc1369e6b34124afd.zip
turn all_nested_unused into used_childs
Diffstat (limited to 'compiler/rustc_resolve/src/check_unused.rs')
-rw-r--r--compiler/rustc_resolve/src/check_unused.rs10
1 files changed, 5 insertions, 5 deletions
diff --git a/compiler/rustc_resolve/src/check_unused.rs b/compiler/rustc_resolve/src/check_unused.rs
index 613709b0cb6..e054847fe5e 100644
--- a/compiler/rustc_resolve/src/check_unused.rs
+++ b/compiler/rustc_resolve/src/check_unused.rs
@@ -299,12 +299,12 @@ fn calc_unused_spans(
 
             let mut unused_spans = Vec::new();
             let mut to_remove = Vec::new();
-            let mut all_nested_unused = true;
+            let mut used_childs = 0;
             let mut previous_unused = false;
             for (pos, (use_tree, use_tree_id)) in nested.iter().enumerate() {
                 let remove = match calc_unused_spans(unused_import, use_tree, *use_tree_id) {
                     UnusedSpanResult::Used => {
-                        all_nested_unused = false;
+                        used_childs += 1;
                         None
                     }
                     UnusedSpanResult::Unused { mut spans, remove } => {
@@ -312,7 +312,7 @@ fn calc_unused_spans(
                         Some(remove)
                     }
                     UnusedSpanResult::PartialUnused { mut spans, remove: mut to_remove_extra } => {
-                        all_nested_unused = false;
+                        used_childs += 1;
                         unused_spans.append(&mut spans);
                         to_remove.append(&mut to_remove_extra);
                         None
@@ -321,7 +321,7 @@ fn calc_unused_spans(
                 if let Some(remove) = remove {
                     let remove_span = if nested.len() == 1 {
                         remove
-                    } else if pos == nested.len() - 1 || !all_nested_unused {
+                    } else if pos == nested.len() - 1 || used_childs > 0 {
                         // Delete everything from the end of the last import, to delete the
                         // previous comma
                         nested[pos - 1].0.span.shrink_to_hi().to(use_tree.span)
@@ -343,7 +343,7 @@ fn calc_unused_spans(
             }
             if unused_spans.is_empty() {
                 UnusedSpanResult::Used
-            } else if all_nested_unused {
+            } else if used_childs == 0 {
                 UnusedSpanResult::Unused { spans: unused_spans, remove: full_span }
             } else {
                 UnusedSpanResult::PartialUnused { spans: unused_spans, remove: to_remove }