diff options
| author | bors <bors@rust-lang.org> | 2022-06-05 09:30:53 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2022-06-05 09:30:53 +0000 |
| commit | 4322a785cc99ea5fc81dd7f5fc8ba7f7a64b08ef (patch) | |
| tree | 4a4a195907d0e90c345e280060c116038fa572a3 /compiler/rustc_resolve | |
| parent | a2da4af33c5e6a22fff0a223f99d53cba4a5aa52 (diff) | |
| parent | cae3c78664a2ed901e5e962707960e45e7cea33d (diff) | |
| download | rust-4322a785cc99ea5fc81dd7f5fc8ba7f7a64b08ef.tar.gz rust-4322a785cc99ea5fc81dd7f5fc8ba7f7a64b08ef.zip | |
Auto merge of #97697 - WaffleLapkin:no_ref_vec, r=WaffleLapkin
Replace `&Vec<_>`s with `&[_]`s It's generally preferable to use `&[_]` since it's one less indirection and it can be created from types other that `Vec`. I've left `&Vec` in some locals where it doesn't really matter, in cases where `TypeFoldable` is expected (`TypeFoldable: Clone` so slice can't implement it) and in cases where it's `&TypeAliasThatIsActiallyVec`. Nothing important, really, I was just a little annoyed by `visit_generic_param_vec` :D r? `@compiler-errors`
Diffstat (limited to 'compiler/rustc_resolve')
| -rw-r--r-- | compiler/rustc_resolve/src/late.rs | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/compiler/rustc_resolve/src/late.rs b/compiler/rustc_resolve/src/late.rs index 288c89b0189..771eeee965b 100644 --- a/compiler/rustc_resolve/src/late.rs +++ b/compiler/rustc_resolve/src/late.rs @@ -631,7 +631,7 @@ impl<'a: 'ast, 'ast> Visitor<'ast> for LateResolutionVisitor<'a, '_, 'ast> { span, }, |this| { - this.visit_generic_param_vec(&bare_fn.generic_params, false); + this.visit_generic_params(&bare_fn.generic_params, false); this.with_lifetime_rib( LifetimeRibKind::AnonymousPassThrough(ty.id, false), |this| walk_list!(this, visit_param, &bare_fn.decl.inputs), @@ -662,7 +662,7 @@ impl<'a: 'ast, 'ast> Visitor<'ast> for LateResolutionVisitor<'a, '_, 'ast> { span, }, |this| { - this.visit_generic_param_vec(&tref.bound_generic_params, false); + this.visit_generic_params(&tref.bound_generic_params, false); this.smart_resolve_path( tref.trait_ref.ref_id, None, @@ -833,7 +833,7 @@ impl<'a: 'ast, 'ast> Visitor<'ast> for LateResolutionVisitor<'a, '_, 'ast> { } fn visit_generics(&mut self, generics: &'ast Generics) { - self.visit_generic_param_vec( + self.visit_generic_params( &generics.params, self.diagnostic_metadata.current_self_item.is_some(), ); @@ -941,7 +941,7 @@ impl<'a: 'ast, 'ast> Visitor<'ast> for LateResolutionVisitor<'a, '_, 'ast> { span, }, |this| { - this.visit_generic_param_vec(&bound_generic_params, false); + this.visit_generic_params(&bound_generic_params, false); this.visit_ty(bounded_ty); for bound in bounds { this.visit_param_bound(bound, BoundKind::Bound) @@ -1116,7 +1116,7 @@ impl<'a: 'ast, 'b, 'ast> LateResolutionVisitor<'a, 'b, 'ast> { } } - fn visit_generic_param_vec(&mut self, params: &'ast Vec<GenericParam>, add_self_upper: bool) { + fn visit_generic_params(&mut self, params: &'ast [GenericParam], add_self_upper: bool) { // For type parameter defaults, we have to ban access // to following type parameters, as the InternalSubsts can only // provide previous type parameters as they're built. We @@ -1870,7 +1870,7 @@ impl<'a: 'ast, 'b, 'ast> LateResolutionVisitor<'a, 'b, 'ast> { fn with_generic_param_rib<'c, F>( &'c mut self, - params: &'c Vec<GenericParam>, + params: &'c [GenericParam], kind: RibKind<'a>, lifetime_kind: LifetimeRibKind, f: F, |