diff options
| author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2020-12-01 23:46:09 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-12-01 23:46:09 +0100 |
| commit | 8b0c31d492e1b9e98c706ed631dffcc2c72913c5 (patch) | |
| tree | 779ef561fdc882a918c5f4f9a2aec159b589866d /compiler/rustc_session/src | |
| parent | 4cbda829c00af2c3ac362c979fa97ea90be0be7d (diff) | |
| parent | 4ed90835615f96f1260c633027bd673cd011ab36 (diff) | |
| download | rust-8b0c31d492e1b9e98c706ed631dffcc2c72913c5.tar.gz rust-8b0c31d492e1b9e98c706ed631dffcc2c72913c5.zip | |
Rollup merge of #79508 - jryans:check-dsymutil-result, r=nagisa
Warn if `dsymutil` returns an error code This checks the error code returned by `dsymutil` and warns if it failed. It also provides the stdout and stderr logs from `dsymutil`, similar to the native linker step. I tried to think of ways to test this change, but so far I haven't found a good way, as you'd likely need to inject some nonsensical args into `dsymutil` to induce failure, which feels too artificial to me. Also, https://github.com/rust-lang/rust/issues/79361 suggests Rust is on the verge of disabling `dsymutil` by default, so perhaps it's okay for this change to be untested. In any case, I'm happy to add a test if someone sees a good approach. Fixes https://github.com/rust-lang/rust/issues/78770
Diffstat (limited to 'compiler/rustc_session/src')
| -rw-r--r-- | compiler/rustc_session/src/config.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/rustc_session/src/config.rs b/compiler/rustc_session/src/config.rs index db16a90cc60..b648e14360c 100644 --- a/compiler/rustc_session/src/config.rs +++ b/compiler/rustc_session/src/config.rs @@ -214,7 +214,7 @@ pub enum SymbolManglingVersion { impl_stable_hash_via_hash!(SymbolManglingVersion); -#[derive(Clone, Copy, PartialEq, Hash)] +#[derive(Clone, Copy, Debug, PartialEq, Hash)] pub enum DebugInfo { None, Limited, |