about summary refs log tree commit diff
path: root/compiler/rustc_ty_utils/src/instance.rs
diff options
context:
space:
mode:
authorMichael Goulet <michael@errs.io>2024-11-30 16:44:58 +0000
committerMichael Goulet <michael@errs.io>2024-11-30 16:45:01 +0000
commit1e655ef21385eee0a3c224523eac316c7c20e8ed (patch)
tree37ba194b99370307781d1e3127e34b33e90745d0 /compiler/rustc_ty_utils/src/instance.rs
parenta3623f20ae18996f31cc4a5a431d8afaa382247e (diff)
downloadrust-1e655ef21385eee0a3c224523eac316c7c20e8ed.tar.gz
rust-1e655ef21385eee0a3c224523eac316c7c20e8ed.zip
Move refinement check out of compare_impl_item
Diffstat (limited to 'compiler/rustc_ty_utils/src/instance.rs')
-rw-r--r--compiler/rustc_ty_utils/src/instance.rs2
1 files changed, 2 insertions, 0 deletions
diff --git a/compiler/rustc_ty_utils/src/instance.rs b/compiler/rustc_ty_utils/src/instance.rs
index ede671b0f0f..eb30169a7d9 100644
--- a/compiler/rustc_ty_utils/src/instance.rs
+++ b/compiler/rustc_ty_utils/src/instance.rs
@@ -219,6 +219,8 @@ fn resolve_associated_item<'tcx>(
             // We check that the impl item is compatible with the trait item
             // because otherwise we may ICE in const eval due to type mismatches,
             // signature incompatibilities, etc.
+            // NOTE: We could also only enforce this in `PostAnalysis`, which
+            // is what CTFE and MIR inlining would care about anyways.
             if trait_item_id != leaf_def.item.def_id
                 && let Some(leaf_def_item) = leaf_def.item.def_id.as_local()
             {