diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-05-25 22:15:19 +0200 | 
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-25 22:15:19 +0200 | 
| commit | 0ded36f729b6fb9fb110692f6725e27f3bf739b0 (patch) | |
| tree | d89343e1c78855a59c9361a5a8a7d5047173ec53 /compiler | |
| parent | 64730a1632f4b13923ee32782cd4718613aea9a3 (diff) | |
| parent | f1a18da4bb6a976cefea5f0341f6898fec436660 (diff) | |
| download | rust-0ded36f729b6fb9fb110692f6725e27f3bf739b0.tar.gz rust-0ded36f729b6fb9fb110692f6725e27f3bf739b0.zip  | |
Rollup merge of #125523 - saethlin:ctrlc-timeout, r=bjorn3
Exit the process a short time after entering our ctrl-c handler Fixes https://github.com/rust-lang/rust/issues/124212 r? `@bjorn3`
Diffstat (limited to 'compiler')
| -rw-r--r-- | compiler/rustc_driver_impl/src/lib.rs | 17 | 
1 files changed, 8 insertions, 9 deletions
diff --git a/compiler/rustc_driver_impl/src/lib.rs b/compiler/rustc_driver_impl/src/lib.rs index 5532eff7be6..2bd58680eef 100644 --- a/compiler/rustc_driver_impl/src/lib.rs +++ b/compiler/rustc_driver_impl/src/lib.rs @@ -57,7 +57,7 @@ use std::process::{self, Command, Stdio}; use std::str; use std::sync::atomic::{AtomicBool, Ordering}; use std::sync::{Arc, OnceLock}; -use std::time::{Instant, SystemTime}; +use std::time::{Duration, Instant, SystemTime}; use time::OffsetDateTime; use tracing::trace; @@ -1502,14 +1502,13 @@ pub fn init_logger(early_dcx: &EarlyDiagCtxt, cfg: rustc_log::LoggerConfig) { pub fn install_ctrlc_handler() { #[cfg(not(target_family = "wasm"))] ctrlc::set_handler(move || { - // Indicate that we have been signaled to stop. If we were already signaled, exit - // immediately. In our interpreter loop we try to consult this value often, but if for - // whatever reason we don't get to that check or the cleanup we do upon finding that - // this bool has become true takes a long time, the exit here will promptly exit the - // process on the second Ctrl-C. - if CTRL_C_RECEIVED.swap(true, Ordering::Relaxed) { - std::process::exit(1); - } + // Indicate that we have been signaled to stop, then give the rest of the compiler a bit of + // time to check CTRL_C_RECEIVED and run its own shutdown logic, but after a short amount + // of time exit the process. This sleep+exit ensures that even if nobody is checking + // CTRL_C_RECEIVED, the compiler exits reasonably promptly. + CTRL_C_RECEIVED.store(true, Ordering::Relaxed); + std::thread::sleep(Duration::from_millis(100)); + std::process::exit(1); }) .expect("Unable to install ctrlc handler"); }  | 
