diff options
| author | Michael Goulet <michael@errs.io> | 2025-06-26 20:15:20 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-06-26 20:15:20 -0400 |
| commit | 58cda76585336dd7ea4748c3616f65e90b3a8116 (patch) | |
| tree | 12df6c135b75f096771f1301b027152ac3cfe20a /library/alloc/src/rc.rs | |
| parent | 25e239c193b3e22d0dc5e8e3eaebd66ed9b7374b (diff) | |
| parent | 644469e9613253321d09887ffe0fb2c98528ee21 (diff) | |
| download | rust-58cda76585336dd7ea4748c3616f65e90b3a8116.tar.gz rust-58cda76585336dd7ea4748c3616f65e90b3a8116.zip | |
Rollup merge of #142700 - theemathas:remove-weak-comment, r=ibraheemdev
Remove incorrect comments in `Weak` It is currently possible to create a dangling `Weak` to a DST by calling `Weak::new()` for a sized type, then doing an unsized coercion. Therefore, the comments are wrong. These comments were added in <https://github.com/rust-lang/rust/pull/73845>. As far as I can tell, the guarantee in the comment was only previously used in the `as_ptr` method. However, the current implementation of `as_ptr` no longer relies on this guarantee.
Diffstat (limited to 'library/alloc/src/rc.rs')
| -rw-r--r-- | library/alloc/src/rc.rs | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/library/alloc/src/rc.rs b/library/alloc/src/rc.rs index 4b8ea708e7e..010d17f7476 100644 --- a/library/alloc/src/rc.rs +++ b/library/alloc/src/rc.rs @@ -3004,7 +3004,6 @@ pub struct Weak< // `Weak::new` sets this to `usize::MAX` so that it doesn’t need // to allocate space on the heap. That's not a value a real pointer // will ever have because RcInner has alignment at least 2. - // This is only possible when `T: Sized`; unsized `T` never dangle. ptr: NonNull<RcInner<T>>, alloc: A, } |