diff options
| author | Manish Goregaokar <manishsmail@gmail.com> | 2020-06-26 00:39:15 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-06-26 00:39:15 -0700 |
| commit | 97ccd9706885d801990372fb88c4ab52817338b9 (patch) | |
| tree | 0167495f1fcb4ddea17c02a9d2aa5dd34cbfe100 /library/std/src/sys/windows/stack_overflow_uwp.rs | |
| parent | 6061752853a672e3058ba763b1fc5b310796ab93 (diff) | |
| parent | 11a3584de4084deabe23354cb387984d6664a4a8 (diff) | |
| download | rust-97ccd9706885d801990372fb88c4ab52817338b9.tar.gz rust-97ccd9706885d801990372fb88c4ab52817338b9.zip | |
Rollup merge of #73719 - davidtwco:issue-72509-emitter-column-width, r=estebank
emitter: column width defaults to 140 Fixes #72509. This PR modifies the column width computation in the emitter when `termize::dimensions` returns `None` so that it uses the default value of 140 (which is used in UI testing currently) instead of `usize::MAX` which just ends up causing overflows in later computations. I also tried changing the computations which used `column_width` with their saturating equivalent, but the output appeared the same - so I decided to go with this approach because I feel like it's less likely to accidentally re-introduce an ICE like this in future (e.g. adding a non-saturating operation on `column_width` in future). I haven't added a test because I couldn't come up with a MCVE. I stumbled upon this running rustc-perf with the `piston-image` benchmark (running in tmux; it only happened with stage two builds only; and only when running through Cargo, not rustc directly with the same flags). In addition, given the nature of the issue, I don't know that we *could* write a UI test for this. Open to suggestions here though. r? @estebank
Diffstat (limited to 'library/std/src/sys/windows/stack_overflow_uwp.rs')
0 files changed, 0 insertions, 0 deletions