about summary refs log tree commit diff
path: root/library/std/src
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2023-09-28 11:47:54 +0000
committerbors <bors@rust-lang.org>2023-09-28 11:47:54 +0000
commitc01d8d238c57f9847e1f1dd5a1d2659b85e2a468 (patch)
treea16453ab270bc0dec21075325e5a2837b1b7bda7 /library/std/src
parente2d6aa77ed3fdb2ec6ceb4ee05429457768a4c0f (diff)
parent6acb415e7c7671c078177a95412987374b30a3c3 (diff)
downloadrust-c01d8d238c57f9847e1f1dd5a1d2659b85e2a468.tar.gz
rust-c01d8d238c57f9847e1f1dd5a1d2659b85e2a468.zip
Auto merge of #114428 - ChaiTRex:master, r=dtolnay
Convert `Into<ExitStatus> for ExitStatusError` to `From<ExitStatusError> for ExitStatus` in `std::process`

Implementing suggestion from https://github.com/rust-lang/rust/issues/84908#issuecomment-912352902:

> I believe the impl on ExitStatusError should be
>
> ```rust
> impl From<ExitStatusError> for ExitStatus
> ```
>
> rather than
>
> ```rust
> impl Into<ExitStatus> for ExitStatusError
> ```
>
> (there is generally never anything implemented as `Into` first, because implementing `From` reflexively provides `Into`)
Diffstat (limited to 'library/std/src')
-rw-r--r--library/std/src/process.rs6
1 files changed, 3 insertions, 3 deletions
diff --git a/library/std/src/process.rs b/library/std/src/process.rs
index 1190d41c924..6cf3bd619b2 100644
--- a/library/std/src/process.rs
+++ b/library/std/src/process.rs
@@ -1807,9 +1807,9 @@ impl ExitStatusError {
 }
 
 #[unstable(feature = "exit_status_error", issue = "84908")]
-impl Into<ExitStatus> for ExitStatusError {
-    fn into(self) -> ExitStatus {
-        ExitStatus(self.0.into())
+impl From<ExitStatusError> for ExitStatus {
+    fn from(error: ExitStatusError) -> Self {
+        Self(error.0.into())
     }
 }