diff options
| author | Yuki Okushi <jtitor@2k36.org> | 2022-07-18 10:02:06 +0900 |
|---|---|---|
| committer | Tshepang Mbambo <tshepang@gmail.com> | 2022-07-18 07:31:14 +0200 |
| commit | e85504c5d693a6ac8793cb2274792e34c6503e38 (patch) | |
| tree | bb48f3a0390d2e6d0060f372b7f5d26727ce2ff1 /src/doc/rustc-dev-guide | |
| parent | 95eaa02681e21ba6267ece2909493491b51aa69b (diff) | |
| download | rust-e85504c5d693a6ac8793cb2274792e34c6503e38.tar.gz rust-e85504c5d693a6ac8793cb2274792e34c6503e38.zip | |
Remove a mention to Steve on r? example
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Diffstat (limited to 'src/doc/rustc-dev-guide')
| -rw-r--r-- | src/doc/rustc-dev-guide/src/contributing.md | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/doc/rustc-dev-guide/src/contributing.md b/src/doc/rustc-dev-guide/src/contributing.md index fed14afbd33..34e0264f45d 100644 --- a/src/doc/rustc-dev-guide/src/contributing.md +++ b/src/doc/rustc-dev-guide/src/contributing.md @@ -78,13 +78,12 @@ to review your request based on which files you changed. If you want to request that a specific person reviews your pull request, you can add an `r?` to the pull request description or in a comment. For example, -[Steve][steveklabnik] usually reviews documentation changes. So if you were to -make a documentation change, add +if you want to ask a review to @awesome-reviewer, add - r? @steveklabnik + r? @awesome-reviewer to the end of the pull request description, and [@rust-highfive][rust-highfive] will assign -[@steveklabnik][steveklabnik] instead of a random person. This is entirely optional. +them instead of a random person. This is entirely optional. You can also assign a random reviewer from a specific team by writing `r? rust-lang/groupname`. So if you were making a diagnostics change, then you could get a reviewer from the diagnostics @@ -135,7 +134,6 @@ speed the process up. Typically only small changes that are expected not to conf with one another are marked as "always roll up". [rust-highfive]: https://github.com/rust-highfive -[steveklabnik]: https://github.com/steveklabnik [@bors]: https://github.com/bors [merge-queue]: https://bors.rust-lang.org/queue/rust |
