diff options
| author | Ralf Jung <post@ralfj.de> | 2021-05-05 13:53:42 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-05 13:53:42 +0200 |
| commit | 861e27723dfd05b4a0e7eb87ad90f3aee101b878 (patch) | |
| tree | b621564a14658d8383c27c7fb35761e2c3d81016 /src/doc/rustc-dev-guide | |
| parent | 2822483dd5f3445b82dd40e8e7c395ed4d8e53ec (diff) | |
| download | rust-861e27723dfd05b4a0e7eb87ad90f3aee101b878.tar.gz rust-861e27723dfd05b4a0e7eb87ad90f3aee101b878.zip | |
add 'waiting-for-review' incantation to main contrib page (#1124)
Diffstat (limited to 'src/doc/rustc-dev-guide')
| -rw-r--r-- | src/doc/rustc-dev-guide/src/contributing.md | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/doc/rustc-dev-guide/src/contributing.md b/src/doc/rustc-dev-guide/src/contributing.md index abe1bb8390b..02ae1159c64 100644 --- a/src/doc/rustc-dev-guide/src/contributing.md +++ b/src/doc/rustc-dev-guide/src/contributing.md @@ -147,8 +147,12 @@ rebase when bringing the latest changes from the master branch to your feature branch. Also, please make sure that fixup commits are squashed into other related commits with meaningful commit messages. -If you encounter merge conflicts, your PR will get marked as `S-waiting-on-author`. -When you resolve them, you should use `@rustbot` to mark it as `S-waiting-on-review`. +If you encounter merge conflicts or when a reviewer asks you to perform some +changes, your PR will get marked as `S-waiting-on-author`. When you resolve +them, you should use `@rustbot` to mark it as `S-waiting-on-review`: + + @rustbot label -S-waiting-on-author +S-waiting-on-review + See [this chapter][labeling] for more details. GitHub allows [closing issues using keywords][closing-keywords]. This feature |