about summary refs log tree commit diff
path: root/src/doc/rustc-dev-guide
diff options
context:
space:
mode:
authormark <markm@cs.wisc.edu>2020-06-02 14:45:37 -0500
committerWho? Me?! <mark-i-m@users.noreply.github.com>2020-06-18 12:16:00 -0500
commit02975c0d47aac0da3e93405a4787cb75e88a6882 (patch)
treead62dd6f5609f3380a0c11e37c2e4432b96096b1 /src/doc/rustc-dev-guide
parentd90d6075bfe5c9480a1cb30414b2255c455b6252 (diff)
downloadrust-02975c0d47aac0da3e93405a4787cb75e88a6882.tar.gz
rust-02975c0d47aac0da3e93405a4787cb75e88a6882.zip
some minor updates
Diffstat (limited to 'src/doc/rustc-dev-guide')
-rw-r--r--src/doc/rustc-dev-guide/src/getting-started.md14
1 files changed, 11 insertions, 3 deletions
diff --git a/src/doc/rustc-dev-guide/src/getting-started.md b/src/doc/rustc-dev-guide/src/getting-started.md
index 1ec7b1b2654..4207fd1eec7 100644
--- a/src/doc/rustc-dev-guide/src/getting-started.md
+++ b/src/doc/rustc-dev-guide/src/getting-started.md
@@ -67,8 +67,9 @@ computationally expensive, so a beefier machine will help, and I wouldn't
 recommend trying to build on a Raspberry Pi :P
 
 - x86 and ARM are both supported (TODO: confirm)
-- Recommended 30GB of free disk space; otherwise, you will have to keep
-  clearing incremental caches.
+- Recommended >=30GB of free disk space; otherwise, you will have to keep
+  clearing incremental caches. More space is better, the compiler is a bit of a
+  hog; it's a problem we are aware of.
 - Recommended >=8GB RAM.
 - Recommended >=2 cores; more cores really helps.
 - You will need an internet connection to build; the bootstrapping process
@@ -146,7 +147,7 @@ After updating `config.toml`, as mentioned above, you can use `./x.py`:
 This will take a while, especially the first time. Be wary of accidentally
 touching or formatting the compiler, as `./x.py` will try to recompile it.
 
-To run the compiler's UI test (the bulk of the test suite):
+To run the compiler's UI test suite (the bulk of the test suite):
 
 ```
 # UI tests
@@ -227,6 +228,13 @@ will be reviewed, approved, and merged. This includes most bug fixes,
 refactorings, and other user-invisible changes. The next few sections talk
 about exceptions to this rule.
 
+Also, note that is perfectly acceptable to open WIP PRs or GitHub [Draft
+PRs][draft]. Some people prefer to do this so they can get feedback along the
+way or share their code with a collaborator. Others do this so they can utilize
+the CI to build and test their PR (e.g. if you are developing on a laptop).
+
+[draft]: https://github.blog/2019-02-14-introducing-draft-pull-requests/
+
 ### New Features
 
 Rust has strong backwards-compatibility guarantees. Thus, new features can't