about summary refs log tree commit diff
path: root/src/doc/rustc-dev-guide
diff options
context:
space:
mode:
authorZack M. Davis <code@zackmdavis.net>2018-06-30 08:55:04 -0700
committerWho? Me?! <mark-i-m@users.noreply.github.com>2018-07-04 17:14:02 -0500
commit3a851001e05ddc15b3447cf160b74bb4b81cddae (patch)
tree36981f4dedf6d7d8953504cae9fd3d4f435be98a /src/doc/rustc-dev-guide
parentfa644901e94fb740741d495f04220a5ebf77694e (diff)
downloadrust-3a851001e05ddc15b3447cf160b74bb4b81cddae.tar.gz
rust-3a851001e05ddc15b3447cf160b74bb4b81cddae.zip
cautionary parenthetical about failing to emit a `DiagnosticBuilder`
Diffstat (limited to 'src/doc/rustc-dev-guide')
-rw-r--r--src/doc/rustc-dev-guide/src/diag.md4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/doc/rustc-dev-guide/src/diag.md b/src/doc/rustc-dev-guide/src/diag.md
index 0bef3e27412..26fc200af69 100644
--- a/src/doc/rustc-dev-guide/src/diag.md
+++ b/src/doc/rustc-dev-guide/src/diag.md
@@ -41,13 +41,15 @@ directly and ones that allow finer control over what to emit. For example,
 [`DiagnosticBuilder`][diagbuild].
 
 `DiagnosticBuilder` allows you to add related notes and suggestions to an error
-before emitting it by calling the [`emit`][emit] method. See the
+before emitting it by calling the [`emit`][emit] method. (Failing to either
+emit or [cancel][cancel] a `DiagnosticBuilder` will result in an ICE.) See the
 [docs][diagbuild] for more info on what you can do.
 
 [spanerr]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc/session/struct.Session.html#method.span_err
 [strspanerr]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc/session/struct.Session.html#method.struct_span_err
 [diagbuild]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_errors/diagnostic_builder/struct.DiagnosticBuilder.html
 [emit]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_errors/diagnostic_builder/struct.DiagnosticBuilder.html#method.emit
+[cancel]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_errors/struct.Diagnostic.html#method.cancel
 
 ```rust,ignore
 // Get a DiagnosticBuilder. This does _not_ emit an error yet.