about summary refs log tree commit diff
path: root/src/etc/gdb_providers.py
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2020-12-02 04:12:33 +0000
committerbors <bors@rust-lang.org>2020-12-02 04:12:33 +0000
commit92e4fb073245a42559e357a3002c596b8b38edf6 (patch)
treea2487afa8d78ed9397f56bb36727162b2d195a41 /src/etc/gdb_providers.py
parenteb4860c7e1e4109d94e84adc2794f720120604e3 (diff)
parent685e1f3e45ef1ffa881be13b6af1867209c294c7 (diff)
downloadrust-92e4fb073245a42559e357a3002c596b8b38edf6.tar.gz
rust-92e4fb073245a42559e357a3002c596b8b38edf6.zip
Auto merge of #79235 - ortem:fix-btreemap-gdb-pretty-printer, r=Mark-Simulacrum
Fix zero-sized BTreeMap gdb pretty-printer

`gdb.parse_and_eval("()")` is needed because GDB treats "()" as a Rust array of two characters, not as a unit

Based on https://github.com/intellij-rust/intellij-rust/pull/6356
Diffstat (limited to 'src/etc/gdb_providers.py')
-rw-r--r--src/etc/gdb_providers.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/etc/gdb_providers.py b/src/etc/gdb_providers.py
index cabf5dccbfe..2d902a9b6e0 100644
--- a/src/etc/gdb_providers.py
+++ b/src/etc/gdb_providers.py
@@ -1,7 +1,6 @@
 from sys import version_info
 
 import gdb
-from gdb import lookup_type
 
 if version_info[0] >= 3:
     xrange = range
@@ -213,7 +212,7 @@ def children_of_btree_map(map):
     def children_of_node(node_ptr, height):
         def cast_to_internal(node):
             internal_type_name = node.type.target().name.replace("LeafNode", "InternalNode", 1)
-            internal_type = lookup_type(internal_type_name)
+            internal_type = gdb.lookup_type(internal_type_name)
             return node.cast(internal_type.pointer())
 
         if node_ptr.type.name.startswith("alloc::collections::btree::node::BoxedNode<"):
@@ -233,8 +232,10 @@ def children_of_btree_map(map):
                     yield child
             if i < length:
                 # Avoid "Cannot perform pointer math on incomplete type" on zero-sized arrays.
-                key = keys[i]["value"]["value"] if keys.type.sizeof > 0 else "()"
-                val = vals[i]["value"]["value"] if vals.type.sizeof > 0 else "()"
+                key_type_size = keys.type.sizeof
+                val_type_size = vals.type.sizeof
+                key = keys[i]["value"]["value"] if key_type_size > 0 else gdb.parse_and_eval("()")
+                val = vals[i]["value"]["value"] if val_type_size > 0 else gdb.parse_and_eval("()")
                 yield key, val
 
     if map["length"] > 0: