diff options
| author | Kevin Butler <haqkrs@gmail.com> | 2015-02-13 07:33:44 +0000 |
|---|---|---|
| committer | Kevin Butler <haqkrs@gmail.com> | 2015-02-18 00:56:07 +0000 |
| commit | 2f586b9687e5c33d9d3b8eccfc309f65d2a9f4e9 (patch) | |
| tree | 578e2d49b5c8b71d7c38142adcf6d10dba09d690 /src/libcollections | |
| parent | 5705d48e280f8a0065c214edfb3dcdcecc323316 (diff) | |
| download | rust-2f586b9687e5c33d9d3b8eccfc309f65d2a9f4e9.tar.gz rust-2f586b9687e5c33d9d3b8eccfc309f65d2a9f4e9.zip | |
Opt for .cloned() over .map(|x| x.clone()) etc.
Diffstat (limited to 'src/libcollections')
| -rw-r--r-- | src/libcollections/bit.rs | 6 | ||||
| -rw-r--r-- | src/libcollections/dlist.rs | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/libcollections/bit.rs b/src/libcollections/bit.rs index ca598a8d4d2..d6e5b3fe464 100644 --- a/src/libcollections/bit.rs +++ b/src/libcollections/bit.rs @@ -2306,7 +2306,7 @@ mod tests { #[test] fn test_from_bools() { let bools = vec![true, false, true, true]; - let bitv: Bitv = bools.iter().map(|n| *n).collect(); + let bitv: Bitv = bools.iter().cloned().collect(); assert_eq!(format!("{:?}", bitv), "1011"); } @@ -2319,12 +2319,12 @@ mod tests { #[test] fn test_bitv_iterator() { let bools = vec![true, false, true, true]; - let bitv: Bitv = bools.iter().map(|n| *n).collect(); + let bitv: Bitv = bools.iter().cloned().collect(); assert_eq!(bitv.iter().collect::<Vec<bool>>(), bools); let long: Vec<_> = (0i32..10000).map(|i| i % 2 == 0).collect(); - let bitv: Bitv = long.iter().map(|n| *n).collect(); + let bitv: Bitv = long.iter().cloned().collect(); assert_eq!(bitv.iter().collect::<Vec<bool>>(), long) } diff --git a/src/libcollections/dlist.rs b/src/libcollections/dlist.rs index 27b282ee9a9..4da6f963006 100644 --- a/src/libcollections/dlist.rs +++ b/src/libcollections/dlist.rs @@ -938,7 +938,7 @@ impl<A: Ord> Ord for DList<A> { #[stable(feature = "rust1", since = "1.0.0")] impl<A: Clone> Clone for DList<A> { fn clone(&self) -> DList<A> { - self.iter().map(|x| x.clone()).collect() + self.iter().cloned().collect() } } @@ -1056,7 +1056,7 @@ mod tests { #[cfg(test)] fn list_from<T: Clone>(v: &[T]) -> DList<T> { - v.iter().map(|x| (*x).clone()).collect() + v.iter().cloned().collect() } #[test] |
