about summary refs log tree commit diff
path: root/src/libcoretest
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2014-08-28 23:56:20 +0000
committerbors <bors@rust-lang.org>2014-08-28 23:56:20 +0000
commit2e92c67dc0318a52fe42c3c0bca408f76c7feb61 (patch)
tree1a90b5802f53f36eda0212ac1b02ebd521161f25 /src/libcoretest
parent1a33d7a54170cd2904cebc7a6fd2d1da471ff64e (diff)
parent9a8233d3772fbdb3d496aac3e4693e6d4c30e125 (diff)
downloadrust-2e92c67dc0318a52fe42c3c0bca408f76c7feb61.tar.gz
rust-2e92c67dc0318a52fe42c3c0bca408f76c7feb61.zip
auto merge of #16664 : aturon/rust/stabilize-option-result, r=alexcrichton
Per API meeting

  https://github.com/rust-lang/meeting-minutes/blob/master/Meeting-API-review-2014-08-13.md

# Changes to `core::option`

Most of the module is marked as stable or unstable; most of the unstable items are awaiting resolution of conventions issues.

However, a few methods have been deprecated, either due to lack of use or redundancy:

* `take_unwrap`, `get_ref` and `get_mut_ref` (redundant, and we prefer for this functionality to go through an explicit .unwrap)
* `filtered` and `while`
* `mutate` and `mutate_or_set`
* `collect`: this functionality is being moved to a new `FromIterator` impl.

# Changes to `core::result`

Most of the module is marked as stable or unstable; most of the unstable items are awaiting resolution of conventions issues.

* `collect`: this functionality is being moved to a new `FromIterator` impl.
* `fold_` is deprecated due to lack of use
* Several methods found in `core::option` are added here, including `iter`, `as_slice`, and variants.

Due to deprecations, this is a:

[breaking-change]
Diffstat (limited to 'src/libcoretest')
-rw-r--r--src/libcoretest/option.rs6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/libcoretest/option.rs b/src/libcoretest/option.rs
index 776637f3be9..2dad9fc3a22 100644
--- a/src/libcoretest/option.rs
+++ b/src/libcoretest/option.rs
@@ -73,7 +73,7 @@ fn test_option_dance() {
     let mut y = Some(5i);
     let mut y2 = 0;
     for _x in x.iter() {
-        y2 = y.take_unwrap();
+        y2 = y.take().unwrap();
     }
     assert_eq!(y2, 5);
     assert!(y.is_none());
@@ -82,8 +82,8 @@ fn test_option_dance() {
 #[test] #[should_fail]
 fn test_option_too_much_dance() {
     let mut y = Some(marker::NoCopy);
-    let _y2 = y.take_unwrap();
-    let _y3 = y.take_unwrap();
+    let _y2 = y.take().unwrap();
+    let _y3 = y.take().unwrap();
 }
 
 #[test]