diff options
| author | Samuel Holland <samuel@sholland.org> | 2019-03-22 17:08:06 -0500 |
|---|---|---|
| committer | Samuel Holland <samuel@sholland.org> | 2019-03-22 21:28:25 -0500 |
| commit | 8d3dd39d885f427faf3898521e7e1e9319d76b91 (patch) | |
| tree | 97a02db95cdd490e80504ff04a6f6cae87684428 /src/librustc_codegen_llvm | |
| parent | 52e885628e4317aa3f158622435927eb29b812e9 (diff) | |
| download | rust-8d3dd39d885f427faf3898521e7e1e9319d76b91.tar.gz rust-8d3dd39d885f427faf3898521e7e1e9319d76b91.zip | |
Correct minimum system LLVM version in tests
Since commit 9452a8dfa3ba, the new debug info format is only generated for LLVM 8 and newer versions. However, the tests still assume that LLVM 7 will use the new debug info format. Fix the tests (and a comment in the code) to match the actual version check.
Diffstat (limited to 'src/librustc_codegen_llvm')
| -rw-r--r-- | src/librustc_codegen_llvm/debuginfo/metadata.rs | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/librustc_codegen_llvm/debuginfo/metadata.rs b/src/librustc_codegen_llvm/debuginfo/metadata.rs index ddcbf29da83..8efa025e3dd 100644 --- a/src/librustc_codegen_llvm/debuginfo/metadata.rs +++ b/src/librustc_codegen_llvm/debuginfo/metadata.rs @@ -1156,12 +1156,14 @@ fn prepare_union_metadata( // Enums //=----------------------------------------------------------------------------- -// DWARF variant support is only available starting in LLVM 7. +// DWARF variant support is only available starting in LLVM 8. // Although the earlier enum debug info output did not work properly // in all situations, it is better for the time being to continue to // sometimes emit the old style rather than emit something completely -// useless when rust is compiled against LLVM 6 or older. This -// function decides which representation will be emitted. +// useless when rust is compiled against LLVM 6 or older. LLVM 7 +// contains an early version of the DWARF variant support, and will +// crash when handling the new debug info format. This function +// decides which representation will be emitted. fn use_enum_fallback(cx: &CodegenCx<'_, '_>) -> bool { // On MSVC we have to use the fallback mode, because LLVM doesn't // lower variant parts to PDB. |
