diff options
| author | Mazdak Farrokhzad <twingoow@gmail.com> | 2019-10-08 15:45:26 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-10-08 15:45:26 +0200 |
| commit | 3c5f8a1da06204c9e22f53ad3930fdc5c48e13a5 (patch) | |
| tree | 1e713a8ce44d9ab18ce9d6c5ae473722ed592d98 /src/librustc_codegen_llvm | |
| parent | 7153c9262a76a6464a4f5aef3d45ffcc41dd87b2 (diff) | |
| parent | 6c9f218f3e1f2bb9a6bc0cdf5a0aa16c220f1ee8 (diff) | |
| download | rust-3c5f8a1da06204c9e22f53ad3930fdc5c48e13a5.tar.gz rust-3c5f8a1da06204c9e22f53ad3930fdc5c48e13a5.zip | |
Rollup merge of #65102 - tmiasko:tsan-probe-stack, r=alexcrichton
Disable stack probe when thread sanitizer is enabled When thread sanitizer instrumentation is enabled during compilation of stack probe function, the function will be miscompiled and trigger segmentation fault at runtime. Disable stack probes when tsan is enabled.
Diffstat (limited to 'src/librustc_codegen_llvm')
| -rw-r--r-- | src/librustc_codegen_llvm/attributes.rs | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/librustc_codegen_llvm/attributes.rs b/src/librustc_codegen_llvm/attributes.rs index 33b50401b22..a0bef5b7815 100644 --- a/src/librustc_codegen_llvm/attributes.rs +++ b/src/librustc_codegen_llvm/attributes.rs @@ -96,10 +96,12 @@ pub fn set_probestack(cx: &CodegenCx<'ll, '_>, llfn: &'ll Value) { } // Currently stack probes seem somewhat incompatible with the address - // sanitizer. With asan we're already protected from stack overflow anyway - // so we don't really need stack probes regardless. - if let Some(Sanitizer::Address) = cx.sess().opts.debugging_opts.sanitizer { - return + // sanitizer and thread sanitizer. With asan we're already protected from + // stack overflow anyway so we don't really need stack probes regardless. + match cx.sess().opts.debugging_opts.sanitizer { + Some(Sanitizer::Address) | + Some(Sanitizer::Thread) => return, + _ => {}, } // probestack doesn't play nice either with `-C profile-generate`. |
