about summary refs log tree commit diff
path: root/src/librustdoc/html/render
diff options
context:
space:
mode:
authorNicholas-Baron <nicholas.baron.ten@gmail.com>2020-11-06 13:24:55 -0800
committerNicholas-Baron <nicholas.baron.ten@gmail.com>2020-11-10 20:07:47 -0800
commit261ca04c925e1844bbd3525168d129055637e60e (patch)
tree052eab1b6fa0810f260cef027039442e5a27fd0d /src/librustdoc/html/render
parent38030ffb4e735b26260848b744c0910a5641e1db (diff)
downloadrust-261ca04c925e1844bbd3525168d129055637e60e.tar.gz
rust-261ca04c925e1844bbd3525168d129055637e60e.zip
Changed unwrap_or to unwrap_or_else in some places.
The discussion seems to have resolved that this lint is a bit "noisy" in
that applying it in all places would result in a reduction in
readability.

A few of the trivial functions (like `Path::new`) are fine to leave
outside of closures.

The general rule seems to be that anything that is obviously an
allocation (`Box`, `Vec`, `vec![]`) should be in a closure, even if it
is a 0-sized allocation.
Diffstat (limited to 'src/librustdoc/html/render')
-rw-r--r--src/librustdoc/html/render/cache.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/librustdoc/html/render/cache.rs b/src/librustdoc/html/render/cache.rs
index cf785d362cd..add28de17ed 100644
--- a/src/librustdoc/html/render/cache.rs
+++ b/src/librustdoc/html/render/cache.rs
@@ -128,7 +128,7 @@ pub fn build_index(krate: &clean::Crate, cache: &mut Cache) -> String {
         .module
         .as_ref()
         .map(|module| shorten(plain_text_summary(module.doc_value())))
-        .unwrap_or(String::new());
+        .unwrap_or_default();
 
     #[derive(Serialize)]
     struct CrateData<'a> {