diff options
| author | Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> | 2022-09-14 19:26:20 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-14 19:26:20 +0530 |
| commit | dce471582a575c905be208d19fcda654207a5233 (patch) | |
| tree | 26029ce23d27b313dba81d37be802892b0e8eed3 /src/librustdoc/html/static/css/rustdoc.css | |
| parent | 706e4d3dd97886317338c82b5b9da8e650d5733c (diff) | |
| parent | e3debdf63c0fac4a844291c3f0847469ebca6e2e (diff) | |
| download | rust-dce471582a575c905be208d19fcda654207a5233.tar.gz rust-dce471582a575c905be208d19fcda654207a5233.zip | |
Rollup merge of #101769 - notriddle:notriddle/out-of-band-span-since, r=GuillaumeGomez
rustdoc: remove redundant CSS `.out-of-band > span.since { position }`
At the time this CSS was added, it was just `span.since`, because the version info could be rendered in two different ways:
1. `<div class='since'>` was used for associated items like methods. It was absolutely positioned, and the selector in rustdoc.css that targetted it was just `.since`.
https://github.com/rust-lang/rust/blob/a5a2f2b951ea982a666eaf52b1874d8f1b17290b/src/librustdoc/html/static/rustdoc.css#L522-L529
2. `<span class='since'>` was introduced in a5a2f2b951ea982a666eaf52b1874d8f1b17290b for page-global version info, so that it could be laid out alongside the `[-]`/`[+]` button. This CSS rule was added to override the absolute position introduced in (1).
https://github.com/rust-lang/rust/blob/a5a2f2b951ea982a666eaf52b1874d8f1b17290b/src/librustdoc/html/static/rustdoc.css#L637-L641
The selector was changed in 8fc6e420d16dc882f2047e6ec1b981cac5ef0d14 so that everything could use a `<span>` tag, but the dichotomy of the absolutely-positioned version info for associated items and the static positioned item version info remained.
The absolutely positioned `.since` was changed to one nested below a `<div class="rightside">` container in 5de1391b88007a1d4f7b1517657a86aae352af1e, so the version information is now always statically-positioned, and, as described in the commit message, "their DOM representation is consistent."
Diffstat (limited to 'src/librustdoc/html/static/css/rustdoc.css')
| -rw-r--r-- | src/librustdoc/html/static/css/rustdoc.css | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/librustdoc/html/static/css/rustdoc.css b/src/librustdoc/html/static/css/rustdoc.css index 600e7cf3a0b..bfd8aa9d4f5 100644 --- a/src/librustdoc/html/static/css/rustdoc.css +++ b/src/librustdoc/html/static/css/rustdoc.css @@ -1267,7 +1267,6 @@ a.test-arrow:hover { } .out-of-band > span.since { - position: initial; font-size: 1.25rem; } |
