diff options
| author | bors <bors@rust-lang.org> | 2017-11-07 07:24:13 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2017-11-07 07:24:13 +0000 |
| commit | 3e7f501991df2f7fc87f6c340945112c128735d2 (patch) | |
| tree | f97c0d2bacbebfa5b4c38099c54a1ef1f3f7a3e1 /src/librustdoc/html | |
| parent | a17e72462fcf4c4b8699fba086ab5363b0bba3bb (diff) | |
| parent | 676b4bbdc40be39d12b811d6871c2df59e93cde9 (diff) | |
| download | rust-3e7f501991df2f7fc87f6c340945112c128735d2.tar.gz rust-3e7f501991df2f7fc87f6c340945112c128735d2.zip | |
Auto merge of #45620 - ollie27:rustdoc_impl_generic_dupe, r=QuietMisdreavus
rustdoc: Fix duplicated impls with generics The same type can appear multiple times in impls so we need to use a set to avoid adding it multiple times. Fixes: #45584
Diffstat (limited to 'src/librustdoc/html')
| -rw-r--r-- | src/librustdoc/html/render.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/librustdoc/html/render.rs b/src/librustdoc/html/render.rs index f3a897d2121..88e1f780d03 100644 --- a/src/librustdoc/html/render.rs +++ b/src/librustdoc/html/render.rs @@ -1326,7 +1326,7 @@ impl DocFolder for Cache { // Figure out the id of this impl. This may map to a // primitive rather than always to a struct/enum. // Note: matching twice to restrict the lifetime of the `i` borrow. - let mut dids = vec![]; + let mut dids = FxHashSet(); if let clean::Item { inner: clean::ImplItem(ref i), .. } = item { let masked_trait = i.trait_.def_id().map_or(false, |d| self.masked_crates.contains(&d.krate)); @@ -1336,7 +1336,7 @@ impl DocFolder for Cache { clean::BorrowedRef { type_: box clean::ResolvedPath { did, .. }, .. } => { - dids.push(did); + dids.insert(did); } ref t => { let did = t.primitive_type().and_then(|t| { @@ -1344,7 +1344,7 @@ impl DocFolder for Cache { }); if let Some(did) = did { - dids.push(did); + dids.insert(did); } } } @@ -1353,7 +1353,7 @@ impl DocFolder for Cache { if let Some(generics) = i.trait_.as_ref().and_then(|t| t.generics()) { for bound in generics { if let Some(did) = bound.def_id() { - dids.push(did); + dids.insert(did); } } } |
