auto merge of #4784 : alexcrichton/rust/bitv-clear-fix, r=graydon

I think that the inversion of `op(&mut w)` may have just been a mistake?

1 files changed, 19 insertions, 1 deletions

diff --git a/src/libstd/bitv.rs b/src/libstd/bitv.rs
index d49c2ef95f6..244d388bffe 100644
--- a/src/libstd/bitv.rs
+++ b/src/libstd/bitv.rs
@@ -156,7 +156,7 @@ impl BigBitv {
      fn each_storage(op: fn(v: &mut uint) -> bool) {
         for uint::range(0, self.storage.len()) |i| {
             let mut w = self.storage[i];
-            let b = !op(&mut w);
+            let b = op(&mut w);
             self.storage[i] = w;
             if !b { break; }
         }
@@ -981,6 +981,24 @@ mod tests {
       assert !b1[40];
       assert !b1[80];
     }
+
+    #[test]
+    pub fn test_small_clear() {
+      let b = Bitv(14, true);
+      b.clear();
+      for b.ones |i| {
+          die!(fmt!("found 1 at %?", i));
+      }
+    }
+
+    #[test]
+    pub fn test_big_clear() {
+      let b = Bitv(140, true);
+      b.clear();
+      for b.ones |i| {
+          die!(fmt!("found 1 at %?", i));
+      }
+    }
 }
 
 //