diff options
| author | Huon Wilson <dbau.pp+github@gmail.com> | 2013-08-13 23:08:14 +1000 |
|---|---|---|
| committer | Huon Wilson <dbau.pp+github@gmail.com> | 2013-08-15 01:10:45 +1000 |
| commit | 53487a02467ebe8816a3bdf03f16c3db958958a2 (patch) | |
| tree | 8d4a4aec4d1260579373f856ecfce70233538a71 /src/libstd/iterator.rs | |
| parent | 58021be45441efc6bf0a10eb58a407f74e9eaed0 (diff) | |
| download | rust-53487a02467ebe8816a3bdf03f16c3db958958a2.tar.gz rust-53487a02467ebe8816a3bdf03f16c3db958958a2.zip | |
std: Move the iterator param on FromIterator and Extendable to the method.
If they are on the trait then it is extremely annoying to use them as
generic parameters to a function, e.g. with the iterator param on the trait
itself, if one was to pass an Extendable<int> to a function that filled it
either from a Range or a Map<VecIterator>, one needs to write something
like:
fn foo<E: Extendable<int, Range<int>> +
Extendable<int, Map<&'self int, int, VecIterator<int>>>
(e: &mut E, ...) { ... }
since using a generic, i.e. `foo<E: Extendable<int, I>, I: Iterator<int>>`
means that `foo` takes 2 type parameters, and the caller has to specify them
(which doesn't work anyway, as they'll mismatch with the iterators used in
`foo` itself).
This patch changes it to:
fn foo<E: Extendable<int>>(e: &mut E, ...) { ... }
Diffstat (limited to 'src/libstd/iterator.rs')
| -rw-r--r-- | src/libstd/iterator.rs | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/libstd/iterator.rs b/src/libstd/iterator.rs index bd89c271a36..1a5e364542b 100644 --- a/src/libstd/iterator.rs +++ b/src/libstd/iterator.rs @@ -26,15 +26,15 @@ use clone::Clone; use uint; /// Conversion from an `Iterator` -pub trait FromIterator<A, T: Iterator<A>> { +pub trait FromIterator<A> { /// Build a container with elements from an external iterator. - fn from_iterator(iterator: &mut T) -> Self; + fn from_iterator<T: Iterator<A>>(iterator: &mut T) -> Self; } /// A type growable from an `Iterator` implementation -pub trait Extendable<A, T: Iterator<A>>: FromIterator<A, T> { +pub trait Extendable<A>: FromIterator<A> { /// Extend a container with the elements yielded by an iterator - fn extend(&mut self, iterator: &mut T); + fn extend<T: Iterator<A>>(&mut self, iterator: &mut T); } /// An interface for dealing with "external iterators". These types of iterators @@ -353,7 +353,7 @@ pub trait Iterator<A> { /// assert!(a == b); /// ~~~ #[inline] - fn collect<B: FromIterator<A, Self>>(&mut self) -> B { + fn collect<B: FromIterator<A>>(&mut self) -> B { FromIterator::from_iterator(self) } |
