about summary refs log tree commit diff
path: root/src/libstd/sys/unix/stack_overflow.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2015-06-20 04:56:46 +0000
committerbors <bors@rust-lang.org>2015-06-20 04:56:46 +0000
commitc057802ca40677179e2fae0452eccb4fd3728a94 (patch)
treeef4a168a5b40ed54910d18202138fb7c0805d73c /src/libstd/sys/unix/stack_overflow.rs
parenta9515698fa456390386087ccb6123ce741f18527 (diff)
parentfcd99aae0a6312ecd79ce3e814a54c6c1373f165 (diff)
downloadrust-c057802ca40677179e2fae0452eccb4fd3728a94.tar.gz
rust-c057802ca40677179e2fae0452eccb4fd3728a94.zip
Auto merge of #26382 - alexcrichton:less-racy-path, r=brson
Environment variables are global state so this can lead to surprising results if
the driver is called in a multithreaded environment (e.g. doctests). There
shouldn't be any memory corruption that's possible, but a lot of the bots have
been failing because they can't find `cc` or `gcc` in the path during doctests,
and I highly suspect that it is due to the compiler modifying `PATH` in a
multithreaded fashion.

This commit moves the logic for appending to `PATH` to only affect the child
process instead of also affecting the parent, at least for the linking stage.
When loading dynamic libraries the compiler still modifies `PATH` on Windows,
but this may be more difficult to fix than spawning off a new process.
Diffstat (limited to 'src/libstd/sys/unix/stack_overflow.rs')
0 files changed, 0 insertions, 0 deletions