diff options
| author | Alex Crichton <alex@alexcrichton.com> | 2015-01-30 12:02:51 -0800 |
|---|---|---|
| committer | Alex Crichton <alex@alexcrichton.com> | 2015-01-30 12:02:51 -0800 |
| commit | b446c5b67994bd9822e958e3e26122543086c1bc (patch) | |
| tree | 316f8a04f62cf15b6ba69e68b628d8a381fa1ece /src/libstd | |
| parent | 9ff540ba3771a1c0a396ca3f7a685a94b4e0f622 (diff) | |
| parent | ff25fd660ac7240f4c8379e74108a462a9aaba77 (diff) | |
| download | rust-b446c5b67994bd9822e958e3e26122543086c1bc.tar.gz rust-b446c5b67994bd9822e958e3e26122543086c1bc.zip | |
rollup merge of #21495: richo/unexported-unmangled-lint
The usecase is that functions made visible to systems outside of the rust ecosystem require the symbol to be visible. This adds a lint for functions that are not exported, but also not mangled. It has some gotchas: [ ]: There is fallout in core that needs taking care of [ ]: I'm not convinced the error message is correct [ ]: It has no tests ~~However, there's an underlying issue which I'd like feedback on- which is that my belief that that non-pub functions would not have their symbols exported, however that seems not to be the case in the first case that this lint turned up in rustc (`rust_fail`), which intuition suggests has been working.~~ This seems to be a separate bug in rust, wherein the symbols are exported in binaries, but not in rlibs or dylibs. This lint would catch that case.
Diffstat (limited to 'src/libstd')
| -rw-r--r-- | src/libstd/rt/unwind.rs | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/libstd/rt/unwind.rs b/src/libstd/rt/unwind.rs index 18298f1c7f4..757aecaaaff 100644 --- a/src/libstd/rt/unwind.rs +++ b/src/libstd/rt/unwind.rs @@ -160,6 +160,7 @@ pub fn panicking() -> bool { // An uninlined, unmangled function upon which to slap yer breakpoints #[inline(never)] #[no_mangle] +#[allow(private_no_mangle_fns)] fn rust_panic(cause: Box<Any + Send>) -> ! { rtdebug!("begin_unwind()"); @@ -237,6 +238,7 @@ pub mod eabi { #[lang="eh_personality"] #[no_mangle] // referenced from rust_try.ll + #[allow(private_no_mangle_fns)] extern fn rust_eh_personality( version: c_int, actions: uw::_Unwind_Action, @@ -290,6 +292,7 @@ pub mod eabi { #[lang="eh_personality"] #[no_mangle] // referenced from rust_try.ll + #[allow(private_no_mangle_fns)] pub extern "C" fn rust_eh_personality( version: c_int, actions: uw::_Unwind_Action, @@ -343,6 +346,7 @@ pub mod eabi { #[lang="eh_personality"] #[no_mangle] // referenced from rust_try.ll + #[allow(private_no_mangle_fns)] extern "C" fn rust_eh_personality( state: uw::_Unwind_State, ue_header: *mut uw::_Unwind_Exception, @@ -432,6 +436,7 @@ pub mod eabi { #[lang="eh_personality"] #[no_mangle] // referenced from rust_try.ll + #[allow(private_no_mangle_fns)] extern "C" fn rust_eh_personality( exceptionRecord: *mut EXCEPTION_RECORD, establisherFrame: *mut c_void, |