diff options
| author | Graydon Hoare <graydon@mozilla.com> | 2012-06-21 16:44:10 -0700 |
|---|---|---|
| committer | Graydon Hoare <graydon@mozilla.com> | 2012-06-21 16:44:10 -0700 |
| commit | 312faf31dfcce7a2d15495c5042d80a3e3b476c9 (patch) | |
| tree | 4ad8383191907b5cb148291a2d1dbc078f590eb6 /src/libsyntax/ext | |
| parent | 57101780811490fa759ed1dca310c405d28c0a72 (diff) | |
| download | rust-312faf31dfcce7a2d15495c5042d80a3e3b476c9.tar.gz rust-312faf31dfcce7a2d15495c5042d80a3e3b476c9.zip | |
Tag all remaining FIXMEs with bugs. Install rule in tidy script to enforce this.
Diffstat (limited to 'src/libsyntax/ext')
| -rw-r--r-- | src/libsyntax/ext/env.rs | 4 | ||||
| -rw-r--r-- | src/libsyntax/ext/expand.rs | 8 | ||||
| -rw-r--r-- | src/libsyntax/ext/fmt.rs | 7 | ||||
| -rw-r--r-- | src/libsyntax/ext/qquote.rs | 4 | ||||
| -rw-r--r-- | src/libsyntax/ext/simplext.rs | 7 |
5 files changed, 14 insertions, 16 deletions
diff --git a/src/libsyntax/ext/env.rs b/src/libsyntax/ext/env.rs index ebb56fa3b58..26a906f8cf0 100644 --- a/src/libsyntax/ext/env.rs +++ b/src/libsyntax/ext/env.rs @@ -11,8 +11,8 @@ fn expand_syntax_ext(cx: ext_ctxt, sp: codemap::span, arg: ast::mac_arg, _body: ast::mac_body) -> @ast::expr { let args = get_mac_args(cx, sp, arg, 1u, option::some(1u), "env"); - // FIXME: if this was more thorough it would manufacture an - // option<str> rather than just an maybe-empty string. (Issue #2248) + // FIXME (#2248): if this was more thorough it would manufacture an + // option<str> rather than just an maybe-empty string. let var = expr_to_str(cx, args[0], "#env requires a string"); alt os::getenv(var) { diff --git a/src/libsyntax/ext/expand.rs b/src/libsyntax/ext/expand.rs index ba44404fe24..26313e97494 100644 --- a/src/libsyntax/ext/expand.rs +++ b/src/libsyntax/ext/expand.rs @@ -109,10 +109,10 @@ fn new_span(cx: ext_ctxt, sp: span) -> span { ret {lo: sp.lo, hi: sp.hi, expn_info: cx.backtrace()}; } -// FIXME: this is a terrible kludge to inject some macros into the default -// compilation environment. When the macro-definition system is substantially -// more mature, these should move from here, into a compiled part of libcore -// at very least. (Issue #2247) +// FIXME (#2247): this is a terrible kludge to inject some macros into +// the default compilation environment. When the macro-definition system +// is substantially more mature, these should move from here, into a +// compiled part of libcore at very least. fn core_macros() -> str { ret diff --git a/src/libsyntax/ext/fmt.rs b/src/libsyntax/ext/fmt.rs index 5ea8b677675..0cc4ba0a570 100644 --- a/src/libsyntax/ext/fmt.rs +++ b/src/libsyntax/ext/fmt.rs @@ -30,11 +30,10 @@ fn expand_syntax_ext(cx: ext_ctxt, sp: span, arg: ast::mac_arg, ret pieces_to_expr(cx, sp, pieces, args); } -// FIXME: A lot of these functions for producing expressions can probably -// be factored out in common with other code that builds expressions. -// FIXME: Cleanup the naming of these functions +// FIXME (#2249): A lot of these functions for producing expressions can +// probably be factored out in common with other code that builds +// expressions. Also: Cleanup the naming of these functions. // NOTE: Moved many of the common ones to build.rs --kevina -// See Issue #2249 fn pieces_to_expr(cx: ext_ctxt, sp: span, pieces: [piece], args: [@ast::expr]) -> @ast::expr { fn make_path_vec(_cx: ext_ctxt, ident: ast::ident) -> [ast::ident] { diff --git a/src/libsyntax/ext/qquote.rs b/src/libsyntax/ext/qquote.rs index 9830c379ef6..3f3eb001250 100644 --- a/src/libsyntax/ext/qquote.rs +++ b/src/libsyntax/ext/qquote.rs @@ -104,8 +104,8 @@ fn gather_anti_quotes<N: qq_helper>(lo: uint, node: N) -> aq_ctxt with *default_visitor()}; let cx = @{lo:lo, gather: dvec()}; node.visit(cx, mk_vt(v)); - // FIXME: Maybe this is an overkill (merge_sort), it might be better - // to just keep the gather array in sorted order ... (Issue #2250) + // FIXME (#2250): Maybe this is an overkill (merge_sort), it might + // be better to just keep the gather array in sorted order. cx.gather.swap { |v| vec::to_mut(std::sort::merge_sort({|a,b| a.lo < b.lo}, v)) }; diff --git a/src/libsyntax/ext/simplext.rs b/src/libsyntax/ext/simplext.rs index bf3014d1621..4dad13dc06a 100644 --- a/src/libsyntax/ext/simplext.rs +++ b/src/libsyntax/ext/simplext.rs @@ -466,8 +466,7 @@ fn p_t_s_rec(cx: ext_ctxt, m: matchable, s: selector, b: binders) { } } } - /* FIXME: handle embedded types and blocks, at least - (Issue #2251) */ + /* FIXME (#2251): handle embedded types and blocks, at least */ expr_mac(mac) { p_t_s_r_mac(cx, mac, s, b); } @@ -722,8 +721,8 @@ fn add_new_extension(cx: ext_ctxt, sp: span, arg: ast::mac_arg, [@{params: pattern_to_selectors(cx, arg), body: elts[1u]}]; - // FIXME: check duplicates (or just simplify - // the macro arg situation) (Issue #2251) + // FIXME (#2251): check duplicates (or just simplify + // the macro arg situation) } _ { cx.span_bug(mac.span, "undocumented invariant in \ |
