diff options
| author | Nick Cameron <ncameron@mozilla.com> | 2014-03-03 10:12:40 -0800 |
|---|---|---|
| committer | Nick Cameron <ncameron@mozilla.com> | 2014-03-04 18:04:16 -0800 |
| commit | 4a891fe80dfc5c64d72ddb842751bf410dc7a3a8 (patch) | |
| tree | 62ae6ffe732fe7f8374740632c59a31d4a542e52 /src/libsyntax/ext | |
| parent | 0a5138c75244ffc0bc639d3060566e8efc83748e (diff) | |
| download | rust-4a891fe80dfc5c64d72ddb842751bf410dc7a3a8.tar.gz rust-4a891fe80dfc5c64d72ddb842751bf410dc7a3a8.zip | |
Expand nested items within a backtrace.
Fixes a regression from #4913 which causes items to be exanded with spans lacking expn_info from the context's current backtrace.
Diffstat (limited to 'src/libsyntax/ext')
| -rw-r--r-- | src/libsyntax/ext/expand.rs | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/src/libsyntax/ext/expand.rs b/src/libsyntax/ext/expand.rs index d8b4334c867..13c340cb774 100644 --- a/src/libsyntax/ext/expand.rs +++ b/src/libsyntax/ext/expand.rs @@ -248,7 +248,7 @@ macro_rules! with_exts_frame ( // When we enter a module, record it, for the sake of `module!` pub fn expand_item(it: @ast::Item, fld: &mut MacroExpander) -> SmallVector<@ast::Item> { - let mut decorator_items = SmallVector::zero(); + let mut decorator_items: SmallVector<@ast::Item> = SmallVector::zero(); for attr in it.attrs.rev_iter() { let mname = attr.name(); @@ -262,20 +262,21 @@ pub fn expand_item(it: @ast::Item, fld: &mut MacroExpander) span: None } }); + // we'd ideally decorator_items.push_all(expand_item(item, fld)), // but that double-mut-borrows fld + let mut items: SmallVector<@ast::Item> = SmallVector::zero(); dec_fn(fld.cx, attr.span, attr.node.value, it, - |item| decorator_items.push(item)); + |item| items.push(item)); + decorator_items.extend(&mut items.move_iter() + .flat_map(|item| expand_item(item, fld).move_iter())); + fld.cx.bt_pop(); } _ => {} } } - let decorator_items = decorator_items.move_iter() - .flat_map(|item| expand_item(item, fld).move_iter()) - .collect(); - let mut new_items = match it.node { ast::ItemMac(..) => expand_item_mac(it, fld), ast::ItemMod(_) | ast::ItemForeignMod(_) => { |
