about summary refs log tree commit diff
path: root/src/rustllvm/ExecutionEngineWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2015-05-19 01:08:54 +0000
committerbors <bors@rust-lang.org>2015-05-19 01:08:54 +0000
commit8dbc3699213965feb422ff9257111f2edb2fc9db (patch)
treec01d8f12a8ea69bf3a5743a00e4245513214c606 /src/rustllvm/ExecutionEngineWrapper.cpp
parent2e7d7bc05db986b9747c7e8b2a766165ab5faeab (diff)
parent5f39ceb729e3bb209e9cf52701fe4424e7431ca0 (diff)
downloadrust-8dbc3699213965feb422ff9257111f2edb2fc9db.tar.gz
rust-8dbc3699213965feb422ff9257111f2edb2fc9db.zip
Auto merge of #25441 - alexcrichton:debug-panic-neg, r=aturon
Debug overflow checks for arithmetic negation landed in #24500, at which time
the `abs` method on signed integers was changed to using `wrapping_neg` to
ensure that the function never panicked. This implied that `abs` of `INT_MIN`
would return `INT_MIN`, another negative value. When this change was back-ported
to beta, however, in #24708, the `wrapping_neg` function had not yet been
backported, so the implementation was changed in #24785 to `!self + 1`. This
change had the unintended side effect of enabling debug overflow checks for the
`abs` function. Consequently, the current state of affairs is that the beta
branch checks for overflow in debug mode for `abs` and the nightly branch does
not.

This commit alters the behavior of nightly to have `abs` always check for
overflow in debug mode. This change is more consistent with the way the standard
library treats overflow as well, and it is also not a breaking change as it's
what the beta branch currently does (albeit if by accident).

cc #25378
Diffstat (limited to 'src/rustllvm/ExecutionEngineWrapper.cpp')
0 files changed, 0 insertions, 0 deletions