about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorjumbatm <30644300+jumbatm@users.noreply.github.com>2020-07-13 23:06:35 +1000
committerjumbatm <30644300+jumbatm@users.noreply.github.com>2020-07-30 21:59:02 +1000
commit060666d0a4cb814328990d271ae9741f2d20cb0d (patch)
treef757bc62d1b9939bb2f05d06ea667b36d866fa55 /src/rustllvm/RustWrapper.cpp
parent5e52edca529ba5051d0bb752c751159d3057ab15 (diff)
downloadrust-060666d0a4cb814328990d271ae9741f2d20cb0d.tar.gz
rust-060666d0a4cb814328990d271ae9741f2d20cb0d.zip
Address code review comments.
- Make `is_repr_nullable_ptr` freestanding again to avoid usage of
ImproperCTypesVisitor in ClashingExternDeclarations (and don't
accidentally revert the ParamEnv::reveal_all() fix from a week earlier)
- Revise match condition for 1 Adt, 1 primitive
- Generalise check for non-null type so that it would also work for
ranges which exclude any single value (all bits set, for example)
- Make is_repr_nullable_ptr return the representable type instead of
just a boolean, to avoid adding an additional, independent "source of
truth" about the FFI-compatibility of Option-like enums. Also, rename to
`repr_nullable_ptr`.
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions