about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorSebastian Geisler <sebastian@blockstream.io>2018-10-30 22:24:33 -0700
committerSebastian Geisler <sebastian@blockstream.io>2018-11-15 22:55:24 -0800
commit6d40b7232eaa00ab5c060582011f350725703a1e (patch)
treef2e1c25c92d32bb635a8df1792e96c32cec199bb /src/rustllvm/RustWrapper.cpp
parente8aef7cae14bc7a56859408c90253e9bcc07fcff (diff)
downloadrust-6d40b7232eaa00ab5c060582011f350725703a1e.tar.gz
rust-6d40b7232eaa00ab5c060582011f350725703a1e.zip
Implement checked_add_duration for SystemTime
Since SystemTime is opaque there is no way to check if the result
of an addition will be in bounds. That makes the Add<Duration>
trait completely unusable with untrusted data. This is a big problem
because adding a Duration to UNIX_EPOCH is the standard way of
constructing a SystemTime from a unix timestamp.

This commit implements checked_add_duration(&self, &Duration) -> Option<SystemTime>
for std::time::SystemTime and as a prerequisite also for all platform
specific time structs. This also led to the refactoring of many
add_duration(&self, &Duration) -> SystemTime functions to avoid
redundancy (they now unwrap the result of checked_add_duration).

Some basic unit tests for the newly introduced function were added
too.
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions