about summary refs log tree commit diff
path: root/src/test/ui/methods
diff options
context:
space:
mode:
authorFelix S. Klock II <pnkfelix@pnkfx.org>2018-10-31 13:08:01 +0100
committerFelix S. Klock II <pnkfelix@pnkfx.org>2018-11-07 13:09:52 +0100
commita2e090624e2246f628786a19581d9aa53d7b2ad0 (patch)
tree032ae8c5bb7f62c55fffd2ecf2240bf52203a241 /src/test/ui/methods
parent0332a39f07f259fc346be91d2cb41d58e8a968b7 (diff)
downloadrust-a2e090624e2246f628786a19581d9aa53d7b2ad0.tar.gz
rust-a2e090624e2246f628786a19581d9aa53d7b2ad0.zip
Removed `#[rustc_error]` from tests that are all `// compile-pass`.
I also added `// skip-codegen` to each one, to address potential concerns
that this change would otherwise slow down our test suite spending time
generating code for files that are really just meant to be checks of
compiler diagnostics.

(However, I will say: My preference is to not use `// skip-codegen` if
one can avoid it. We can use all the testing of how we drive LLVM that
we can get...)

(Updated post rebase.)
Diffstat (limited to 'src/test/ui/methods')
-rw-r--r--src/test/ui/methods/method-call-lifetime-args-subst-index.rs6
-rw-r--r--src/test/ui/methods/method-call-lifetime-args-subst-index.stderr8
2 files changed, 3 insertions, 11 deletions
diff --git a/src/test/ui/methods/method-call-lifetime-args-subst-index.rs b/src/test/ui/methods/method-call-lifetime-args-subst-index.rs
index a9505e4f936..43a18fba9b8 100644
--- a/src/test/ui/methods/method-call-lifetime-args-subst-index.rs
+++ b/src/test/ui/methods/method-call-lifetime-args-subst-index.rs
@@ -8,7 +8,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-#![feature(rustc_attrs)]
+// compile-pass
 #![allow(unused)]
 
 struct S;
@@ -21,5 +21,5 @@ fn test() {
     S.early_and_type::<u16>();
 }
 
-#[rustc_error]
-fn main() {} //~ ERROR compilation successful
+
+fn main() {}
diff --git a/src/test/ui/methods/method-call-lifetime-args-subst-index.stderr b/src/test/ui/methods/method-call-lifetime-args-subst-index.stderr
deleted file mode 100644
index 2848ff88c17..00000000000
--- a/src/test/ui/methods/method-call-lifetime-args-subst-index.stderr
+++ /dev/null
@@ -1,8 +0,0 @@
-error: compilation successful
-  --> $DIR/method-call-lifetime-args-subst-index.rs:25:1
-   |
-LL | fn main() {} //~ ERROR compilation successful
-   | ^^^^^^^^^^^^
-
-error: aborting due to previous error
-