diff options
| author | Eduard-Mihai Burtescu <edy.burt@gmail.com> | 2018-09-28 22:54:18 +0300 |
|---|---|---|
| committer | Eduard-Mihai Burtescu <edy.burt@gmail.com> | 2018-09-28 23:35:01 +0300 |
| commit | 81ca8ebee229ec85d9d2c54d7eda7fd0106a34f3 (patch) | |
| tree | 54c651b4c5b11ff6131acafa76a285410f541385 /src/test/ui/rust-2018 | |
| parent | e90985acdec9928da9f6d157cfeb64f0ee98bffe (diff) | |
rustc_typeck: don't lint non-extern-prelude extern crate's in Rust 2018.
Diffstat (limited to 'src/test/ui/rust-2018')
| -rw-r--r-- | src/test/ui/rust-2018/remove-extern-crate.fixed | 6 | ||||
| -rw-r--r-- | src/test/ui/rust-2018/remove-extern-crate.rs | 6 | ||||
| -rw-r--r-- | src/test/ui/rust-2018/remove-extern-crate.stderr | 8 |
3 files changed, 16 insertions, 4 deletions
diff --git a/src/test/ui/rust-2018/remove-extern-crate.fixed b/src/test/ui/rust-2018/remove-extern-crate.fixed index cdae815b200..34c7266b637 100644 --- a/src/test/ui/rust-2018/remove-extern-crate.fixed +++ b/src/test/ui/rust-2018/remove-extern-crate.fixed @@ -14,6 +14,7 @@ // aux-build:remove-extern-crate.rs // compile-flags:--extern remove_extern_crate +#![feature(alloc)] #![warn(rust_2018_idioms)] @@ -22,11 +23,16 @@ use remove_extern_crate; #[macro_use] extern crate remove_extern_crate as something_else; +// Shouldn't suggest changing to `use`, as the `alloc` +// crate is not in the extern prelude - see #54381. +extern crate alloc; + fn main() { another_name::mem::drop(3); another::foo(); remove_extern_crate::foo!(); bar!(); + alloc::vec![5]; } mod another { diff --git a/src/test/ui/rust-2018/remove-extern-crate.rs b/src/test/ui/rust-2018/remove-extern-crate.rs index 4984da802c0..570bbb02f72 100644 --- a/src/test/ui/rust-2018/remove-extern-crate.rs +++ b/src/test/ui/rust-2018/remove-extern-crate.rs @@ -14,6 +14,7 @@ // aux-build:remove-extern-crate.rs // compile-flags:--extern remove_extern_crate +#![feature(alloc)] #![warn(rust_2018_idioms)] extern crate core; @@ -22,11 +23,16 @@ use remove_extern_crate; #[macro_use] extern crate remove_extern_crate as something_else; +// Shouldn't suggest changing to `use`, as the `alloc` +// crate is not in the extern prelude - see #54381. +extern crate alloc; + fn main() { another_name::mem::drop(3); another::foo(); remove_extern_crate::foo!(); bar!(); + alloc::vec![5]; } mod another { diff --git a/src/test/ui/rust-2018/remove-extern-crate.stderr b/src/test/ui/rust-2018/remove-extern-crate.stderr index 064a853625f..847ba5f3544 100644 --- a/src/test/ui/rust-2018/remove-extern-crate.stderr +++ b/src/test/ui/rust-2018/remove-extern-crate.stderr @@ -1,24 +1,24 @@ warning: unused extern crate - --> $DIR/remove-extern-crate.rs:19:1 + --> $DIR/remove-extern-crate.rs:20:1 | LL | extern crate core; | ^^^^^^^^^^^^^^^^^^ help: remove it | note: lint level defined here - --> $DIR/remove-extern-crate.rs:17:9 + --> $DIR/remove-extern-crate.rs:18:9 | LL | #![warn(rust_2018_idioms)] | ^^^^^^^^^^^^^^^^ = note: #[warn(unused_extern_crates)] implied by #[warn(rust_2018_idioms)] warning: `extern crate` is not idiomatic in the new edition - --> $DIR/remove-extern-crate.rs:20:1 + --> $DIR/remove-extern-crate.rs:21:1 | LL | extern crate core as another_name; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert it to a `use` warning: `extern crate` is not idiomatic in the new edition - --> $DIR/remove-extern-crate.rs:33:5 + --> $DIR/remove-extern-crate.rs:39:5 | LL | extern crate core; | ^^^^^^^^^^^^^^^^^^ help: convert it to a `use` |