about summary refs log tree commit diff
path: root/src/test
diff options
context:
space:
mode:
authorRich Kadel <richkadel@google.com>2020-10-30 16:09:05 -0700
committerRich Kadel <richkadel@google.com>2020-11-05 18:24:18 -0800
commita7d956583ceae1487ad9b0748039bc9f0e8ac7aa (patch)
tree18fbdf8ee28787e044247590ed4f3119aee5ba70 /src/test
parent1973f84ebbb3b2bb4b9a1488b6553ac46b2db8d4 (diff)
downloadrust-a7d956583ceae1487ad9b0748039bc9f0e8ac7aa.tar.gz
rust-a7d956583ceae1487ad9b0748039bc9f0e8ac7aa.zip
Responded to all feedback as of 2020-10-30
Diffstat (limited to 'src/test')
-rw-r--r--src/test/run-make-fulldeps/coverage-spanview-base/Makefile1
-rw-r--r--src/test/run-make-fulldeps/coverage/coverage_tools.mk5
2 files changed, 6 insertions, 0 deletions
diff --git a/src/test/run-make-fulldeps/coverage-spanview-base/Makefile b/src/test/run-make-fulldeps/coverage-spanview-base/Makefile
index ecb5275e716..ec93ca4725e 100644
--- a/src/test/run-make-fulldeps/coverage-spanview-base/Makefile
+++ b/src/test/run-make-fulldeps/coverage-spanview-base/Makefile
@@ -26,6 +26,7 @@ endif
 			-Zinstrument-coverage \
 			-Clink-dead-code=$(LINK_DEAD_CODE) \
 			-Zdump-mir=InstrumentCoverage \
+			-Zdump-mir-spanview \
 			-Zdump-mir-dir="$(TMPDIR)"/mir_dump.$@
 
 	for path in "$(TMPDIR)"/mir_dump.$@/*; do \
diff --git a/src/test/run-make-fulldeps/coverage/coverage_tools.mk b/src/test/run-make-fulldeps/coverage/coverage_tools.mk
index ad5f465c54f..17f7696a8cf 100644
--- a/src/test/run-make-fulldeps/coverage/coverage_tools.mk
+++ b/src/test/run-make-fulldeps/coverage/coverage_tools.mk
@@ -37,3 +37,8 @@ endif
 # tests can be simplified to always test with `-C link-dead-code`.
 
 UNAME = $(shell uname)
+
+# FIXME(richkadel): Can any of the features tested by `run-make-fulldeps/coverage-*` tests be tested
+# just as completely by more focused unit tests of the code logic itself, to reduce the number of
+# test result files generated and maintained, and to help identify specific test failures and root
+# causes more easily?