diff options
| author | bors <bors@rust-lang.org> | 2025-07-18 16:27:59 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2025-07-18 16:27:59 +0000 |
| commit | 8f08b3a32478b8d0507732800ecb548a76e0fd0c (patch) | |
| tree | abdd62e27dec75c21bc2569e90a650de0513fb2c /src/tools | |
| parent | 82310651b93a594a3fd69015e1562186a080d94c (diff) | |
| parent | 7662731d75ceb19f6242c61a6812c22809e6adc2 (diff) | |
| download | rust-8f08b3a32478b8d0507732800ecb548a76e0fd0c.tar.gz rust-8f08b3a32478b8d0507732800ecb548a76e0fd0c.zip | |
Auto merge of #143845 - cjgillot:stability-query, r=jieyouxu
Split-up stability_index query
This PR aims to move deprecation and stability processing away from the monolithic `stability_index` query, and directly implement `lookup_{deprecation,stability,body_stability,const_stability}` queries.
The basic idea is to:
- move per-attribute sanity checks into `check_attr.rs`;
- move attribute compatibility checks into the `MissingStabilityAnnotations` visitor;
- progressively dismantle the `Annotator` visitor and the `stability_index` query.
The first commit contains functional change, and now warns when `#[automatically_derived]` is applied on a non-trait impl block. The other commits should not change visible behaviour.
Perf in https://github.com/rust-lang/rust/pull/143845#issuecomment-3066308630 shows small but consistent improvement, except for unused-warnings case. That case being a stress test, I'm leaning towards accepting the regression.
This PR changes `check_attr`, so has a high conflict rate on that file. This should not cause issues for review.
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/clippy/clippy_lints/src/std_instead_of_core.rs | 2 | ||||
| -rw-r--r-- | src/tools/clippy/clippy_utils/src/qualify_min_const_fn.rs | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/tools/clippy/clippy_lints/src/std_instead_of_core.rs b/src/tools/clippy/clippy_lints/src/std_instead_of_core.rs index cf70e883bd0..216f168471e 100644 --- a/src/tools/clippy/clippy_lints/src/std_instead_of_core.rs +++ b/src/tools/clippy/clippy_lints/src/std_instead_of_core.rs @@ -249,7 +249,7 @@ fn is_stable(cx: &LateContext<'_>, mut def_id: DefId, msrv: Msrv) -> bool { let stable = match since { StableSince::Version(v) => msrv.meets(cx, v), StableSince::Current => msrv.current(cx).is_none(), - StableSince::Err => false, + StableSince::Err(_) => false, }; if !stable { diff --git a/src/tools/clippy/clippy_utils/src/qualify_min_const_fn.rs b/src/tools/clippy/clippy_utils/src/qualify_min_const_fn.rs index 942c71ac33b..b3356450d38 100644 --- a/src/tools/clippy/clippy_utils/src/qualify_min_const_fn.rs +++ b/src/tools/clippy/clippy_utils/src/qualify_min_const_fn.rs @@ -432,7 +432,7 @@ pub fn is_stable_const_fn(cx: &LateContext<'_>, def_id: DefId, msrv: Msrv) -> bo let const_stab_rust_version = match since { StableSince::Version(version) => version, StableSince::Current => RustcVersion::CURRENT, - StableSince::Err => return false, + StableSince::Err(_) => return false, }; msrv.meets(cx, const_stab_rust_version) |