diff options
| author | Chris Denton <chris@chrisdenton.dev> | 2025-04-19 15:09:33 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-04-19 15:09:33 +0000 |
| commit | aad59a30de461e58f47d0147e6f40975aa4416a1 (patch) | |
| tree | ec20e64281740ec4ef68137a548379e9731154f9 /src/tools | |
| parent | 237064a0c47a35be7e876503f35eb5957d96cf71 (diff) | |
| parent | 4a5369b476fb17aa2db05b5b551eca0cfa6b2c6b (diff) | |
| download | rust-aad59a30de461e58f47d0147e6f40975aa4416a1.tar.gz rust-aad59a30de461e58f47d0147e6f40975aa4416a1.zip | |
Rollup merge of #139091 - mejrs:format, r=compiler-errors
Rewrite on_unimplemented format string parser.
This PR rewrites the format string parser for `rustc_on_unimplemented` and `diagnostic::on_unimplemented`. I plan on moving this code (and more) into the new attribute parsing system soon and wanted to PR it separately.
This PR introduces some minor differences though:
- `rustc_on_unimplemented` on trait *implementations* is no longer checked/used - this is actually never used (outside of some tests) so I plan on removing it in the future.
- for `rustc_on_unimplemented`, it introduces the `{This}` argument in favor of `{ThisTraitname}` (to be removed later). It'll be easier to parse.
- for `rustc_on_unimplemented`, `Self` can now consistently be used as a filter, rather than just `_Self`. It used to not match correctly on for example `Self = "[{integer}]"`
- Some error messages now have better spans.
Fixes https://github.com/rust-lang/rust/issues/130627
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/tidy/src/issues.txt | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/tools/tidy/src/issues.txt b/src/tools/tidy/src/issues.txt index d2ae9b1f6ef..5fa4a9fc2e3 100644 --- a/src/tools/tidy/src/issues.txt +++ b/src/tools/tidy/src/issues.txt @@ -3138,7 +3138,6 @@ ui/nll/user-annotations/issue-55241.rs ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs ui/nll/user-annotations/issue-57731-ascibed-coupled-types.rs ui/numbers-arithmetic/issue-8460.rs -ui/on-unimplemented/issue-104140.rs ui/or-patterns/issue-64879-trailing-before-guard.rs ui/or-patterns/issue-67514-irrefutable-param.rs ui/or-patterns/issue-68785-irrefutable-param-with-at.rs |