diff options
| author | Lukas Wirth <me@lukaswirth.dev> | 2025-06-10 08:52:41 +0200 |
|---|---|---|
| committer | Lukas Wirth <me@lukaswirth.dev> | 2025-06-11 11:49:44 +0200 |
| commit | ac4e3657764256fc2411ccbc0e23c451c4338107 (patch) | |
| tree | 40d3b3929cc4890d31318bc7b8831503538d1d4b /src/tools | |
| parent | 3bae562b51452906e7f8046f984d8e861c0e8bc5 (diff) | |
| download | rust-ac4e3657764256fc2411ccbc0e23c451c4338107.tar.gz rust-ac4e3657764256fc2411ccbc0e23c451c4338107.zip | |
fix: Hide dyn inlay hints for incomplete `impl`s
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/rust-analyzer/crates/ide/src/inlay_hints/implied_dyn_trait.rs | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/src/tools/rust-analyzer/crates/ide/src/inlay_hints/implied_dyn_trait.rs b/src/tools/rust-analyzer/crates/ide/src/inlay_hints/implied_dyn_trait.rs index 32d130503a4..cd01c075832 100644 --- a/src/tools/rust-analyzer/crates/ide/src/inlay_hints/implied_dyn_trait.rs +++ b/src/tools/rust-analyzer/crates/ide/src/inlay_hints/implied_dyn_trait.rs @@ -22,9 +22,14 @@ pub(super) fn hints( let parent = paren.as_ref().and_then(|it| it.parent()).unwrap_or(parent); if ast::TypeBound::can_cast(parent.kind()) || ast::TypeAnchor::can_cast(parent.kind()) - || ast::Impl::cast(parent) - .and_then(|it| it.trait_()) - .is_some_and(|it| it.syntax() == path.syntax()) + || ast::Impl::cast(parent).is_some_and(|it| { + it.trait_().map_or( + // only show it for impl type if the impl is not incomplete, otherwise we + // are likely typing a trait impl + it.assoc_item_list().is_none_or(|it| it.l_curly_token().is_none()), + |trait_| trait_.syntax() == path.syntax(), + ) + }) { return None; } @@ -85,6 +90,7 @@ impl T {} // ^ dyn impl T for (T) {} // ^^^ dyn +impl T "#, ); } |
