diff options
| author | Jon Gjengset <jon@thesquareplanet.com> | 2017-04-08 14:03:17 -0400 |
|---|---|---|
| committer | Jon Gjengset <jon@thesquareplanet.com> | 2017-04-08 14:03:17 -0400 |
| commit | f093d59c31bd2064328e24d0ec76e0d105fc32fc (patch) | |
| tree | 5d2f9c1fcaef4a49cd973dc7c18e2f153cb11bf3 /src | |
| parent | e6597e12bc40a28ed4c682e71f7159b9cb2403e7 (diff) | |
| download | rust-f093d59c31bd2064328e24d0ec76e0d105fc32fc.tar.gz rust-f093d59c31bd2064328e24d0ec76e0d105fc32fc.zip | |
Address @parched's comments
Diffstat (limited to 'src')
| -rw-r--r-- | src/doc/unstable-book/src/compiler-barriers.md | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/doc/unstable-book/src/compiler-barriers.md b/src/doc/unstable-book/src/compiler-barriers.md index 9e137a5c4f8..827447f0bd5 100644 --- a/src/doc/unstable-book/src/compiler-barriers.md +++ b/src/doc/unstable-book/src/compiler-barriers.md @@ -22,8 +22,9 @@ compiler is allowed to do. Specifically, depending on the given ordering semantics, the compiler may be disallowed from moving reads or writes from before or after the call to the other side of the call to `compiler_barrier`. Note that it does **not** prevent the *hardware* -from doing such re-orderings -- for that, the `volatile_*` class of -functions, or full memory fences, need to be used. +from doing such re-ordering. This is not a problem in a single-threaded, +execution context, but when other threads may modify memory at the same +time, stronger synchronization primitives are required. ## Examples @@ -92,12 +93,6 @@ fn signal_handler() { } ``` -In more advanced cases (for example, if `IMPORTANT_VARIABLE` was an -`AtomicPtr` that starts as `NULL`), it may also be unsafe for the -compiler to hoist code using `IMPORTANT_VARIABLE` above the -`IS_READY.load`. In that case, a `compiler_barrier(Ordering::Acquire)` -should be placed at the top of the `if` to prevent this optimizations. - A deeper discussion of compiler barriers with various re-ordering semantics (such as `Ordering::SeqCst`) is beyond the scope of this text. Curious readers are encouraged to read the Linux kernel's discussion of |
