diff options
| author | Felix S. Klock II <pnkfelix@pnkfx.org> | 2016-05-25 14:52:40 +0200 |
|---|---|---|
| committer | Felix S. Klock II <pnkfelix@pnkfx.org> | 2016-05-25 14:52:40 +0200 |
| commit | d9680f5b36b10cadf0de01b2ef6df0bec899e3b6 (patch) | |
| tree | 20b041d7942d205c4d4e5506767465eeb1b7f915 /src | |
| parent | 4412c7ab375452badb2b5052e6b78a87e2c36260 (diff) | |
| download | rust-d9680f5b36b10cadf0de01b2ef6df0bec899e3b6.tar.gz rust-d9680f5b36b10cadf0de01b2ef6df0bec899e3b6.zip | |
Fix some comments.
Diffstat (limited to 'src')
| -rw-r--r-- | src/librustc_borrowck/borrowck/mir/dataflow/mod.rs | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/src/librustc_borrowck/borrowck/mir/dataflow/mod.rs b/src/librustc_borrowck/borrowck/mir/dataflow/mod.rs index dad0c925186..da7a85c1a8a 100644 --- a/src/librustc_borrowck/borrowck/mir/dataflow/mod.rs +++ b/src/librustc_borrowck/borrowck/mir/dataflow/mod.rs @@ -324,9 +324,9 @@ pub trait BitDenotation { /// "transfer-function" represnting the overall-effect of the /// block, represented via GEN and KILL sets. /// - /// The statement here is `idx_stmt.1`; `idx_stmt.0` is just - /// an identifying index: namely, the index of the statement - /// in the basic block. + /// The statement is identified as `bb_data[idx_stmt]`, where + /// `bb_data` is the sequence of statements identifed by `bb` in + /// the MIR. fn statement_effect(&self, ctxt: &Self::Ctxt, sets: &mut BlockSets<Self::Idx>, @@ -341,10 +341,6 @@ pub trait BitDenotation { /// "transfer-function" represnting the overall-effect of the /// block, represented via GEN and KILL sets. /// - /// The terminator here is `idx_term.1`; `idx_term.0` is just an - /// identifying index: namely, the number of statements in `bb` - /// itself. - /// /// The effects applied here cannot depend on which branch the /// terminator took. fn terminator_effect(&self, @@ -367,6 +363,11 @@ pub trait BitDenotation { /// flow-dependent, the current MIR cannot encode them via just /// GEN and KILL sets attached to the block, and so instead we add /// this extra machinery to represent the flow-dependent effect. + /// + /// FIXME: Right now this is a bit of a wart in the API. It might + /// be better to represent this as an additional gen- and + /// kill-sets associated with each edge coming out of the basic + /// block. fn propagate_call_return(&self, ctxt: &Self::Ctxt, in_out: &mut IdxSet<Self::Idx>, |
